| Issue Number | 4608 |
|---|---|
| Summary | [Gene Name Display] Display italicized text (e.g., gene names) for DIS on Cancer.gov |
| Created | 2019-04-17 14:06:36 |
| Issue Type | Bug |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2020-05-12 15:21:33 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.242849 |
DIS including gene names appear italicized in QC reports but not in PP or on Cancer.gov.
The Vemurafenib DIS is a good example; it has gene tags around “BRAF.”
CDR ID: 709542
Cancer.gov: https://www.cancer.gov/about-cancer/treatment/drugs/vemurafenib
This isn't a CDR issue because the CDR vendor output is producing the markup correctly. This will need to be addressed at the WCMS end.
Is that the reason why the ticket was assigned to you, ~bkline?
Possibly. Don't really know.
This ticket relates to two other tickets to have the gene names displayed in italics but I think this ticket is a little bit different because - correct me if I'm wrong - all (or most) of the gene names would also be glossary terms. On Cancer.gov the glossary terms are displayed via the modal box. This might make implementing this change a little more difficult. Also, I will need to look into how this would be handled using the new dictionary API.
~juther, I have updated the DIS filter to display the GeneName element in italics. The title of this ticket lists "[Gene Name Display]" but it also specifies "Display italicized text (e.g., gene names) ...".
Are there other elements that should be included here?
Good question. The issue was identified because of a gene name, but other elements this could apply to include the Emphasis element and the Scientific Name element. Are we including Emphasis and Sci Name in the related issues? We probably ought to be consistent across the three "gene name" issues, but I don't know if we have used emphasis or scientific name elements in the DIS.
In the summaries we have the Emphasis, GeneName, ScientificName, and ForeignWord marked up in italics. I'm doing the same for the DIS now. However, only the GeneName is getting its own CSS class name for now as that's what I had discussed with the Digital Platform team.
The following filter has been updated:
CDR797104 - Drug Information Summary for Drupal CMS
https://github.com/NCIOCPL/cdr-server/commit/74373253
This is ready for review on DEV.
How should we test this one? CDR709542 looks good in Publish Preview, but I don't know if that's adequate or if we need to try to publish it.
PublishPreview should be good enough but I could also hot-fix a document on DEV if you like.
Here is the published version on Cancer.gov - DEV:
https://www-dev-acsf.cancer.gov/about-cancer/treatment/drugs/vemurafenib
Great, thanks! That looks good.
~volker, CDR709542 (vemurafenib) looks good in Pub Preview on QA. Would you be able to publish it to Cancer.gov-QA so we can test it there as well? Thanks!
~juther, I've published the document on QA but I can't tell you for sure if this is the updated document:
https://www-test-ac.cancer.gov/about-cancer/treatment/drugs/vemurafenib
~volker, should we republish this DIS on PROD for the changes to go into effect? I expected this to happen automatically.
https://www.cancer.gov/about-cancer/treatment/drugs/vemurafenib
The reprocessing didn't happen automatically because the changes were not part of the vendor filter set but the filter that prepares the documents for Drupal which is using the output of the vendor filter set. Since the vendor filter set didn't change the DIS output didn't change and since the DIS vendor output didn't change the software didn't try to push the document which would have triggered a reprocessing.
I have run a republishing job on this document and you can now see the gene name text properly displayed in italics on our site.
Looks great! Thank you!
Verified on PROD.
Elapsed: 0:00:00.001663