CDR Tickets

Issue Number 4607
Summary Filter for Org QC Report needs some styling
Created 2019-04-17 13:10:11
Issue Type Bug
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2019-04-18 18:02:25
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.242845
Description

While testing the global changes for org documents I noticed that the Org QC report needs some "beautification".  

  • The date at the top of the report is missing

  • The comment fields are wrapped in a border

  • Same for the TollFreePhone field

  • The HTML is still using the deprecated FONT and BASEFONT tags

The changes need to be made to CDR50 (Organization QC Report Filter),

Comment entered 2019-04-18 14:50:55 by Englisch, Volker (NIH/NCI) [C]

It seems the filters had been restored in the CDR but not all of them were restored in Github.

Comment entered 2019-04-18 18:02:15 by Englisch, Volker (NIH/NCI) [C]

I've restored the following filters in git which were already restored in the CDR.

  • CDR50 - Organization QC Report Filter

  • CDR100 - Denormalization Filter (1/1): Organization

  • CDR315593 - Sort OrganizationName for Postal Address - Organization

  • CDR315594 - Copy XML for Organization

The following filters have been updated to fix the formatting issues:

  • CDR50 - Organization QC Report Filter

  • CDR423177 - Module: Organization QC Common

This is ready for review on DEV, .

Comment entered 2019-04-22 16:07:21 by Englisch, Volker (NIH/NCI) [C]

What did you do to create the output with the frame around the comment cells?  Which document, which report did you use?

Comment entered 2019-04-22 17:02:48 by Osei-Poku, William (NIH/NCI) [C]

The document is CDR0000033976 and I generated it the same way we generate QC reports, by clicking on the QC report icon.

Comment entered 2019-04-22 17:27:47 by Englisch, Volker (NIH/NCI) [C]

I'm unable to reproduce the issue on DEV.

Comment entered 2019-04-22 17:34:18 by Englisch, Volker (NIH/NCI) [C]

What browser are you using?  I see the behavior of your screenshot in Chrome but not IE.  The XMetaL users IE as the default browser.

Comment entered 2019-04-22 17:35:09 by Osei-Poku, William (NIH/NCI) [C]

This is the report I generated earlier. I will try the report on another laptop to see if I get a different results. 

Comment entered 2019-04-22 17:36:28 by Osei-Poku, William (NIH/NCI) [C]

IE. I just used the default browser to generate the report.

Comment entered 2019-04-22 17:40:42 by Englisch, Volker (NIH/NCI) [C]

The issue has now been fixed for Chrome as well.

Comment entered 2019-04-22 17:43:10 by Englisch, Volker (NIH/NCI) [C]

That's odd.  It must be a different version of IE that we are using.   Anyway, the problem should be resolved now.

Comment entered 2019-04-22 17:44:53 by Osei-Poku, William (NIH/NCI) [C]

It looks good on another laptop and I see a slight difference in the versions of IE. So, that may be the problem.

Comment entered 2019-04-22 18:28:03 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2019-04-23 13:30:20 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated on QA and are ready to be previewed:

  • CDR50 - Organization QC Report Filter

  • CDR423177 - Module: Organization QC Common

Comment entered 2019-04-23 16:51:11 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2019-04-23 16:56:51 by Englisch, Volker (NIH/NCI) [C]

Should I go ahead and push these changes to PROD?

Comment entered 2019-04-23 16:57:45 by Osei-Poku, William (NIH/NCI) [C]

Yes, please.

Comment entered 2019-04-23 17:19:01 by Englisch, Volker (NIH/NCI) [C]

The filters have been updated on PROD.

  • CDR50 - Organization QC Report Filter

  • CDR423177 - Module: Organization QC Common

https://github.com/NCIOCPL/cdr-server/pull/33/commits/0fcf46c

Comment entered 2019-04-25 09:50:51 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Attachments
File Name Posted User
adminInfoComment.JPG 2019-04-22 15:42:20 Osei-Poku, William (NIH/NCI) [C]
adminInfocomment1.JPG 2019-04-22 17:34:55 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.001713