| Issue Number | 4508 |
|---|---|
| Summary | [DIS] Comments Display |
| Created | 2018-08-01 12:45:06 |
| Issue Type | New Feature |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2018-10-16 10:08:33 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.230335 |
Please show comments in the DIS QC report the same way comments are displayed in the HP QC reports. I will provide specific examples of how they should display.
show comments in the DIS QC report the same way comments are displayed in the HP QC reports
First of all I'm guessing you would need an additional ticket to adjust the CSS for XMetaL because the comments aren't displayed properly, i.e. inside lists or a para level comment doesn't get displayed with the Comment-label or the green background.
Secondly, we're allowing internal, external, permanent, advisory, and editorial type comments. The type(s) of comment to be displayed as part of the QA reports needs to be selected. Please indicate which type(s) of comments need to be included and what the default display should be.
Since there are no boards for the DIS, we should just stick with Comment and Response to Comment without including all the different types. Also, I think the CSS is fine. We don't intend to use Comments in list items.
I'm assuming when you're saying stick with Comment without including all the different types you mean that you're not going to use the internal/external/permanent/etc. attributes and a Comment element will just use all of the default settings of its attributes.
If I don't understand your comment correctly we would need to create new Comment elements because the comments used for Summaries can't be changed, so we couldn't just remove those attributes. We could create a DIS-Comment without any attributes, for instance.
Are you saying it is easier to include all the options but then we just use the defaults? That should be fine. The DISs don't need all the attributes and can just use the default attributes.
It turns out the comments are already included in the QC report,
however, the display is suppressed by CSS. The summary comments are
controlled by the intermediary page where the user can check the type of
comments to be displayed on or off.
I will have to "teach" the QC report for the DIS which set of
comment related variables should be checked. This could either be done
in one of the filters or the program QcReports.py
The following file has been updated (branch cdr4508-DIScomments):
QcReports.py
https://github.com/NCIOCPL/cdr-admin/commit/5745c32a
This is ready for review on DEV.
Unfortunately, since the fix was not a filter change the ticket isn't Release independent.
I don't see a comment that this ticket was checked on DEV, ~oseipokuw.
Verified on DEV. Thanks!
The changes have been merged into the release branch Joule:
Verified on QA. Thanks!
Christina and I discussed comments in the DIS and she would like to have the CSS fixed in order to be able to view the comments more clearly (including comments within list items). I added OCECDR-4646 to Kepler to address this.
Verified on PROD. Thanks!
Elapsed: 0:00:00.001809