CDR Tickets
| Issue Number | 4507 |
|---|---|
| Summary | [Glossary - Media] Modify Audio Request Spreadsheet report |
| Created | 2018-08-01 11:33:24 |
| Issue Type | New Feature |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2019-06-20 17:59:30 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.230329 |
1. We want to include all published terms that do not have a media link, whether they have pronunciation keys or not.
2. We want to be able to include "old" terms on the report even if they have been included in earlier spreadsheets in the past. That is, as long as they do not have a media link, include them on the spreadsheet.
3. We also want to be able to Include Spanish terms that do not have a media link even if the English has a media link. There are cases where the English may have a media link but the Spanish does not and the other way around. In such cases, as long one of the terms (English or Spanish) does not have a media link, please include it on the spreadsheet and if both do not have media link, please include them on the spreadsheet.
4. Exclude terms (that are without audio links) from the spreadsheet when they have been specifically tagged (as exclude from spreadsheet). *Please see below.
*We want to avoid the case where a term (acronym or codes name, for example) never drops off the spreadsheet. So, we would want a way to tag terms in the CDR that may never have a recording.
Also, since it would be possible now to have terms that are being re-recorded. That is, terms that previously had audio pronunciation media docs but they have been removed from the terms because the terms have been revised. Our preference would be to re-use the existing media docs for the terms instead of creating new media docs (new version on top of existing media doc). However, if that is not possible, creating a new media doc should be fine.
Just want to confirm that this is a permanent request. If so, we will retire the table which we needed for tracking which glossary terms had already had a request generated for the audio file(s).
Yes, it is permanent. Alternatively, if an ad hoc query or another report can retrieve such terms, that would be great.
You may want to reword the logic in that second paragraph above. The way it reads now, we'd pick up rows in the report for everything except what falls in the red box in the middle of the diagram below.
For the last request above (reuse of an existing media document), that happens in a different program, so you'll want to create a different ticket (added in Kepler). Since the audio link is no longer present, you'll need to come up with a way to specify the CDR ID of the existing document you want to use for the sound clip in the spreadsheet fed to that program.
Agreed. I have removed the confusing part and created the 4th paragraph. I hope this is better.
> ... we would want a way to tag terms in the CDR that may never have a recording.
~oseipokuw: does this
mean your flag to avoid including the term will be document-wide? Or did
you really mean that you want to flag specific term name strings this
way? In either case, do you have a preference for what the attribute
should be called? Something like NeedsRecording="No"?
We want to flag specif terms. I suggest AudioRecording = "No" for the attribute.
> We want to include all terms that do not have a media link, whether they have pronunciation keys or not.
~oseipokuw - does this mean we should drop the code which excludes documents which are not on the web site?
No. It should be a higher priority than the newly proposed changed.
OK, requirements wording changed accordingly above.
Bob will add a column to the spreadsheet with the heading "Reuse Media ID". This will be used to enter the media IDs for any pronunciations that are being re-recorded so that Bob doesn't create new media docs for them.
~juther - I made you a member of the Audio Import/Spreadsheet group on DEV and gave that group the AUDIO IMPORT permission (which had formerly only been granted to the Developers group, presumably because of the risk involved in running the report when it wrote to the database), so you can test this ticket on DEV.
Changes (CGI code and schema) implemented on DEV. Ready for user testing.
https://github.com/NCIOCPL/cdr-admin/commit/7a956684
https://github.com/NCIOCPL/cdr-server/commit/c7b49589
https://github.com/NCIOCPL/cdr-server/commit/60f19dec
Add database/ocecdr-4507.py to manual tasks (dropping
glossary_term_audio_request table).
Verified the report on DEV. It works as expected. We would like to try out the use of the new column, "Reuse Media ID" for re-recordings. I will let you know when we are ready. Thanks!
Not sure what you mean by "try out the use of the new column," since the enhancement to support using that column is a Kepler ticket (OCECDR-4633).
Sorry, I had forgotten that it would be implemented in Kepler.
Verified on DEV.
Verified on QA.
Verified on PROD. Thanks!
| File Name | Posted | User |
|---|---|---|
| image-2019-06-19-17-55-23-888.png | 2019-06-19 17:55:24 | Kline, Bob (NIH/NCI) [C] |
Elapsed: 0:00:00.001765