| Issue Number | 4433 |
|---|---|
| Summary | Rewrite the global change subsystem |
| Created | 2018-03-08 08:18:45 |
| Issue Type | Improvement |
| Submitted By | Kline, Bob (NIH/NCI) [C] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2018-05-11 12:58:09 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.222345 |
The global change harness is badly in need of a rewrite. I have patched the software so that it doesn't blow up in the case represented by OCECDR-4401, but the original design did not properly take into account non-ASCII values. The organization of the code is also overly complicated and difficult to maintain.
The ModifyDocs module has been completely rewritten, and a moderate amount of testing has been done. Code walkthrough with Volker is planned for Tuesday. I have also made the corresponding changes to the one-off global change template and the CGI script for Audio Import, which will need to be tested by the users. A number of obsolete modules and script have been retired. I'm still doing my own testing and tweaking.
https://github.com/NCIOCPL/cdr-lib/commit/e0930f7
https://github.com/NCIOCPL/cdr-lib/commit/672e19b
https://github.com/NCIOCPL/cdr-lib/commit/2353408
https://github.com/NCIOCPL/cdr-admin/commit/7410c9b3
https://github.com/NCIOCPL/cdr-tools/commit/cfbecb1
https://github.com/NCIOCPL/cdr-lib/commit/9c56d6a
Added a couple of tweaks from yesterday's code walkthrough.
Elapsed: 0:00:00.001710