CDR Tickets

Issue Number 4412
Summary [DIS] Global to Update URLs with "govdel"
Created 2018-02-05 14:52:16
Issue Type Task
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2018-02-21 14:11:14
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.220796
Description

We have about 40 DIS with incorrect URLs that redirect to the correct URLs. Because the URLs were copied from gov delivery, they contain extra characters at the end that should be stripped.

We could provide a spreadsheet with the CDR ID, drug name, and incorrect URL along with the specific characters that should be truncated from the end of the URL ("?cid=eb_govdel”). Would it be possible to tie this in with the other DIS global (OCECDR-4408)?

Comment entered 2018-02-05 16:16:46 by Kline, Bob (NIH/NCI) [C]

Not sure what you mean by "tie this in ...." We can certainly do them around the same time, but they'd be different scripts (and we'd want them to be under separate tickets).

Comment entered 2018-02-16 06:34:44 by Kline, Bob (NIH/NCI) [C]

Please go ahead and provide the spreadsheet. Thanks.

Comment entered 2018-02-16 13:46:26 by Juthe, Robin (NIH/NCI) [E]

I've posted the spreadsheet. Please remove the following characters from the URLs in the listed documents: ?cid=eb_govdel
As you can see, these are all links to Cancer Currents blog posts. Please let us know if you need anything else.

Comment entered 2018-02-19 15:34:52 by Kline, Bob (NIH/NCI) [C]

This will be an usual process, as it doesn't appear that the values we're changing for this global change are present on any tier but PROD. I can't really run a global change in test mode directly on the production server, so I ran it from my desktop, pointing at the PROD tier, and copied the test output to the DEV server. So the URL for reviewing the test results points to DEV, but the documents come from PROD.

https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2018-02-19_15-19-32

Comment entered 2018-02-20 16:47:03 by Juthe, Robin (NIH/NCI) [E]

Ha! So daring. Results look good - please run in live mode when you get a chance (if that's possible?).

Comment entered 2018-02-20 16:52:30 by Kline, Bob (NIH/NCI) [C]

I won't be able to do it until Thursday, because I just lost access to the VPN (someone dropped the ball on the GFE laptop I was supposed to be provided with months ago).

Comment entered 2018-02-21 14:11:14 by Kline, Bob (NIH/NCI) [C]

I figured out a way to do it from my developer virtual machine. Please verify (and close the ticket if everything looks OK).

Comment entered 2018-02-22 10:04:57 by dblais

I looked at a healthy sample of these and they look good. I wasn't checking for this and it may not matter but i noticed that Neratinib had the 'dross removal' version listed twice.

I have a question. These are now corrected on PROD. How do they get pushed to cancer.gov? Do they have to be made publishable individually? (I hope not.)

Comment entered 2018-02-22 10:30:23 by Kline, Bob (NIH/NCI) [C]

They're already publishable (at least for the ones that already had publishable versions). They should get pushed out with the weekly publishing job this Friday.

Comment entered 2018-02-22 10:33:40 by dblais

Awesome! Thanks so much!

Attachments
File Name Posted User
16Feb2018IncorrectURLsInDISs.xls 2018-02-16 13:44:13 Juthe, Robin (NIH/NCI) [E]
test-code-in-production.png 2018-02-19 15:33:42 Kline, Bob (NIH/NCI) [C]

Elapsed: 0:00:00.001524