CDR Tickets

Issue Number 4384
Summary [Citations] Citations imported without publishable versions
Created 2018-01-12 13:53:49
Issue Type Bug
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2018-02-22 14:55:05
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.219737
Description

When new citations are imported, publishable versions of the documents are not created even though that is what the notifications says after the import. Here is one document I just imported.
CDR0000791995

Comment entered 2018-01-12 16:26:49 by Kline, Bob (NIH/NCI) [C]

This is indeed a bug, and I would even agree that it could be legitimate to prioritize it as "Major," but it's been there since the summer of 2002, so I don't think we can say it's been introduced by the Gauss changes. :-)

Let's put this in Hawking, please.

Comment entered 2018-01-18 12:35:13 by Osei-Poku, William (NIH/NCI) [C]

Updated title and removed from Gauss queue.

Comment entered 2018-02-21 16:29:21 by Juthe, Robin (NIH/NCI) [E]

I just noticed that none of the PubMed citations imported since Gauss went live have been made publishable (see attachment). This is causing validation errors and I think it may explain why we are unable to run several summary QC reports (see OCECDR-4423). Are we sure this isn't a new bug?

Comment entered 2018-02-21 16:31:14 by Juthe, Robin (NIH/NCI) [E]

Adding in case this is related to OCECDR-4423.

Comment entered 2018-02-21 17:32:04 by Kline, Bob (NIH/NCI) [C]

After looking at the history of the cdr.py module, I believe you're right. The Citation import script didn't change, but the default used to be to create a publishable version even if the caller didn't ask for one, and that's no longer true. I think the proper fix would be to change the Citation import script to explicitly request a publishable version (rather than change the default back to creating publishable versions which weren't explicitly requested).

Comment entered 2018-02-22 14:55:05 by Kline, Bob (NIH/NCI) [C]

Fixed on DEV, I think. Please test.

Comment entered 2018-02-26 11:48:45 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2018-02-26 12:11:24 by Kline, Bob (NIH/NCI) [C]

Patch applied to QA. Request to apply patch to STAGE and PROD has been submitted to CBIIT (NCI-REQ0101148).

Comment entered 2018-02-27 13:30:31 by Juthe, Robin (NIH/NCI) [E]

I verified this on QA.

Comment entered 2018-02-28 10:10:30 by Kline, Bob (NIH/NCI) [C]

This has been installed on STAGE and PROD. Please verify (and close ticket if appropriate).

Comment entered 2018-02-28 14:13:35 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD. Thanks!

Attachments
File Name Posted User
Citations wo Pub Versions.docx 2018-02-21 16:30:30 Juthe, Robin (NIH/NCI) [E]

Elapsed: 0:00:00.001443