Issue Number | 4366 |
---|---|
Summary | [Glossary] Display VideoLink elements on GTC Full QC Report |
Created | 2018-01-05 13:55:06 |
Issue Type | Improvement |
Submitted By | Juthe, Robin (NIH/NCI) [E] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2018-04-10 13:26:01 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.219388 |
Please display VideoLink elements on the Glossary Term Concept Full QC Report.
Example of a concept with a VideoLink: Metastasis GTC (CDR622340)
Adding Margaret and William as watchers.
We don't have EmbeddedVideo elements included in any of our
QC reports at this point.
How would we want to display this element? For a MediaLink we're
displaying the media document MediaTitle element and the image. What do
we want to display for a video?
Should we display a placeholder, the link to YouTube, or nothing along
with the MediaTitle?
After discussing the report with Robin we decided to represent the element EmbeddedVideo with an image placeholder for the video and a link to YouTube allowing the user to view the image.
The following program has been modified:
GlossaryConceptFull.py
https://github.com/NCIOCPL/cdr-admin/commit/2605e7bc
[ hawking ]
The full QC report returns a python script error. Here is a sample GTC 622340
The report works for me. What is the error you're getting?
This is the error message:
-> -> -->
A problem occurred in a Python script.
D:\cdr\Log\tmprc4pma.html contains the description of this error.
Arghh! Today is not my day. I was looking on DEV because I tested the
New Published Glossary Terms report.
I'll check it out on QA now.
You had included Spanish SpecificMediaTitle elements that my code didn't handle properly.
Please try again on QA.
It is showing now. Thanks!
The program did not display the SpecificMediaTitle instead of the VideoID title if it exists. This has been fixed in
GlossaryConceptFull.py
https://github.com/NCIOCPL/cdr-admin/commit/ee97eaf
[ hawking ]
Volker, would it be possible to make the video screenshot a bit smaller on this QC report? I don't know if the illustration size is standardized on the QC report, but it could be the same size as that if it is. Thanks.
I'm guessing the size is the same as the size of the video would
be.
I don't think we have any "standard" for the size of the images. We can
start to create a standard now. :-)
The image above is 300px wide. Should we try the same width for the
screenshot?
Please have a look on DEV for the modified video display size.
Updated the following program to adjust the image size:
GlossaryConceptFull.py
https://github.com/NCIOCPL/cdr-admin/commit/3f67ef2
[ hawking ]
This looks good to me on DEV. Please promote to QA. Thanks!
The changes have been copied to QA.
Verified on QA. Thanks!
Verified on PROD. Thanks!
Elapsed: 0:00:00.001206