| Issue Number | 4319 |
|---|---|
| Summary | Fix link type management interface |
| Created | 2017-09-26 08:17:37 |
| Issue Type | Bug |
| Submitted By | Kline, Bob (NIH/NCI) [C] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2018-03-05 15:05:54 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.214838 |
The Edit Link Type page only has space for three link sources for a new link type. When you save the new type you get three more blank field sets for link sources if you used all three of the original source field sets, but if you try to add more sources at this point and save the changes, you get an error message saying you're trying to add a new link type which already exists. So to create a new link type with more than three linking sources, you have to:
Go to the "Manage Linking Tables" page
Click "Add New Link Type"
Fill in the form, including the first three linking sources
Click Save Changes
Click Link Menu
Click the new link type's menu item
Add up to the next three sources
Click Save Changes
Repeat steps 5-8 as necessary
This is silly. Fix it.
This is not something which can be done outside of a release.
Rewritten to eliminate superfluous steps and to support deletion of obsolete link types.
~volker: Please give this a look on QA (DEV is pretty much useless at the moment), and provide any feedback you have. Thanks.
https://github.com/NCIOCPL/cdr-admin/commit/866ca5ec
https://github.com/NCIOCPL/cdr-admin/commit/a92adfb6
This is silly.
I thought we like silly. :-)
~oseipokuw, I'm trying to add a type and receive an error message:
Invalid check type 'A'How would I add a new link?
That was a bug. Please try again.
OK, no more silliness. However, I only tested the modified interface. I did not test if the added links are working properly. Did you want me to take a look at that as well?
One thing I noticed that's a little different from other management pages is the response to the save. Here I noticed a small message in the yellow header bar when most of our other pages display a more obvious message. The first time I saved the changes I looked at the content of the page and did not notice the 'Saved' message at all.
We probably want to be consistent with the way we're giving feedback to the users across the site when we're working on the ticket to adjust the pages layout.
How do you like it now?
Wunderbar!
Looks good on QA.
Elapsed: 0:00:00.001187