| Issue Number | 4320 |
|---|---|
| Summary | GovDelivery Reports with Incorrect Date Range |
| Created | 2017-10-02 14:38:06 |
| Issue Type | Bug |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2017-10-19 15:25:38 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.215124 |
The GovDelivery reports ran on Sunday, Oct. 1st as scheduled. However, instead of running the report for the date range of 2017-09-24 through 2017-10-01 the report was running for the week before that (17th through 24th).
I reran the report on PROD specifying the date range manually. In addition, I modified the parameters to exclude the running of the GD trials report since this is now obsolete.
I was able to identify the root of the problem but I'm not able to
properly explain it and I'll leave that up to ~bkline. :-)
As far as I can the the problem is the usage of class variables instead
of instance variables for the definition of the date range values. Class
variables are set only when the scheduler is started while instance
variables are set when the report runs.
I'm currently testing the changes on DEV.
The changes fixed the problem and the report was running with the correct date range now. The changes have been included as part of Fermi:
gov_delivery_reports.py
https://github.com/NCIOCPL/cdr-fermi/commit/39b2372
How do you recommend we test this?
We can submit this report manually from the scheduler on two different days. The date range for both reports should be different. With the current report the date range would be identical unless the scheduler has been restarted.
Ah, okay - that makes sense. Would you have time to submit this report today (and again tomorrow or Thursday)? If possible, could it be sent to you, me, Margaret, and Diana only so we don't confuse anyone else? Thanks!
Since you haven't asked me for any favors in the last two weeks I think I can do that. :-)
Verified on QA.
Last Sunday the GovDelivery report ran for the first time since Fermi is on PROD without a specific date range specified and the report picked the correct range automatically.
Closing this ticket.
Elapsed: 0:00:00.001371