CDR Tickets

Issue Number 4299
Summary Incomplete linking causes error message with no useful information in XMetal
Created 2017-08-08 14:48:05
Issue Type Task
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2018-03-15 08:05:32
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.212571
Description

When a user is creating a link to a Media doc, for example, but fails to complete the Ctrl + Enter macro, and thus leaving the element blank, the attached error message is generated. It is however, difficult to know exactly what is wrong in the document because of the nature of the error message.

Comment entered 2017-08-08 14:49:38 by Osei-Poku, William (NIH/NCI) [C]

This was first reported in OCECDR-4126

Comment entered 2017-08-08 15:18:47 by Kline, Bob (NIH/NCI) [C]

... the attached error message is generated.

I don't see an attachment.

Comment entered 2017-08-08 15:24:19 by Osei-Poku, William (NIH/NCI) [C]

I have just added it.

Comment entered 2018-03-14 18:02:16 by Kline, Bob (NIH/NCI) [C]

Please provide the exact steps for reproducing this behavior. I performed the following steps:

  1. created a new GlossaryTermName document on DEV

  2. eliminated all of the optional elements from the template

  3. added a MediaLink element

  4. brought up the "Edit Linked CDR Element" dialog box for the MediaLink element

  5. backed out of the dialog box without completing the operation

  6. repeated steps 4 and 5 for the GlossaryTermConcept element

  7. saved the document

  8. validated the document (schema only)

  9. validated the document (schema and link validation)

At no point did I see the error message you described above.

Comment entered 2018-03-14 19:53:08 by Osei-Poku, William (NIH/NCI) [C]

Looks like this is happening in summary documents.

1. Open a summary document
2. Add a new empty Media Link
3. Don't link any media doc
4. Save the document
5. Run a schema validation check

The error message would be displayed.
The error message displaying on QA for me appears to be slightly different from the one on PROD.

Comment entered 2018-03-15 08:05:32 by Kline, Bob (NIH/NCI) [C]

Thanks, that was very helpful. It's always a good idea to provide detailed instructions for reproducing the behavior which an issue is reporting.

The validation query to check for links to Media documents with a caption in the appropriate language and for the appropriate audience has been modified to guard against the user neglecting to provide the linked document's CDR ID (on DEV).

https://github.com/NCIOCPL/cdr-server/commit/6111ba5f

Comment entered 2018-03-15 13:01:16 by Osei-Poku, William (NIH/NCI) [C]

Could you please explain this further? I am not sure if you're talking about validation during publishing or the regular link validation in XMetal.

Comment entered 2018-03-15 13:26:39 by Kline, Bob (NIH/NCI) [C]

Validation during publishing is DTD validation. This is CDR Schema validation (not link validation).

TL;DR - the error message you reported is gone (on DEV).

Comment entered 2018-03-22 16:46:36 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2018-04-06 21:10:34 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA.

Comment entered 2018-05-10 12:48:52 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Attachments
File Name Posted User
Not%20linking.png 2017-08-08 15:24:03 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.000681