| Issue Number | 4271 |
|---|---|
| Summary | Summary Fragments Refs not working in PP for replaced docs |
| Created | 2017-05-17 15:15:37 |
| Issue Type | Bug |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2017-07-27 16:43:02 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.208477 |
When a summary has been replaced (using the Replace Doc with New Doc tool), internal Summary Fragment Refs appear not to work in PP although the links work correctly on Cancer.gov. The link appears to be pointing to the replaced/blocked doc in PP instead when you look at the URL of the error page. Please see attached screenshot. This sample document is for CDR0000258102 - Adult Soft Tissue Sarcoma Treatment, patient summary. PP comes up without any problem but when you attempt to click on the link "Treatment Option Overview", which is a live link, you get the attached error and the URL in the error page points to the replaced or blocked doc 62681. I have been able to confirm this behavior only in patient summaries.
We ran into this same problem before. It's a bug resulting from the assumption that only one and only one summary can contain a particular xref attribute value within the system when this is only true when limiting our search on active documents.
The fix requires a change to the program
PublishPreview.py
The problem is that the program rewrites the links in the output
coming from GK but searching the document containing the SummaryURL
given. Since this URL exists twice, once for the active and once for the
replaced document the first - and wrong - CDR-ID is being picked
up.
As a work-around we would need to modify the xref value
of the blocked summary (CDR62681).
For my information:
Change the SQL query to
SELECT doc_id
FROM query_term
JOIN active_doc a
ON a.id = doc_id
WHERE (path = '/Summary/SummaryMetaData/SummaryURL/@cdr:xref'
OR
path = '/DrugInformationSummary/DrugInfoMetaData/URL/@cdr:xref'
)
AND value like '%soft-tissue-sarcoma/patient/adult-soft-tissue-treatment-pdq'
I modified the summary URL on PROD and QA. The link on QA works but the link on PROD doesn't work. The link on PROD appears to be live but when you click on it, nothing happens. Please take a look. Thanks
I see. Unfortunately, this is now a different problem.
You fixed the problem using the work-around in order to have the correct link created. The correct link is now created, however, the link is now requiring JavaScript to work. This is the same problem that only shows the video space but not the video itself. It's something the latest FEQ update broke and we're putting tests in place to look for these things next time a FEQ release is being reviewed.
I'm adding ~sunvw, so she can track that the video issue affects the linking in PP as well.
Adding ~learnb who is looking at a fix for the issues caused by the latest FEQ release.
The broken video requires a GateKeeper release. Details are in [OCEPROJECT-4503].
The right nav is also not displaying in Pub Preview. I'm guessing this is related to the JavaScript issues mentioned above?
That's correct!
The workaround works now but I am leaving this open for the bug fix.
William/Volker, I think I've encountered another instance of this problem with the Cancer Genetics Risk Assessment and Counseling summary (CDR62865). William, if you understand the work-around, can you please try to fix this temporarily for me? We are trying to publish this summary this week. Thanks.
I'm adding this ticket to Feynman since we already have a fix which merely needs to be copied to PROD.
The change has been implemented on DEV:
R14843: PublishPreview.py
Please verify on DEV.
Verified on DEV. Thank you!
~oseipokuw, would you be able to verify this on PROD?
Yes. This is working on PROD now. Thank you!!
I suppose I can close it now, right?
| File Name | Posted | User |
|---|---|---|
| summaryfragmentreferror.png | 2017-05-17 15:17:36 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.001207