CDR Tickets

Issue Number 4238
Summary Markup of Media Link block does not display in RLSO QC Report
Created 2017-03-11 12:12:45
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2017-03-22 13:15:20
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.204540
Description

When a medial link block is marked up to be deleted, the markup does not show up in the RLSO report. This happens even if you markup the whole block. Please modify the QC report to display the changes.

Comment entered 2017-03-17 16:55:29 by Englisch, Volker (NIH/NCI) [C]

Could you prepare a sample document that shows this, ?

I've added three MediaLink elements to the Small Intesting Cancer Treatment HP summary on DEV (CDR62902), one without markup, one with parts of the caption marked-up and one with the entire MediaLink placed within markup. All of the marked-up text appears properly displayed.

Comment entered 2017-03-20 15:43:10 by Osei-Poku, William (NIH/NCI) [C]

If you look at the third image where you've marked up the entire image block,
"Image: brain, lateral and medial, adult, anatomy" is not marked up in the QC report. It seems to be no different from the first image where there is no markup except that in the third image, the caption is showing the markup. Is it possible to show the ImageID as marked up in the QC report just as it is in XMetal?

Comment entered 2017-03-20 16:06:08 by Englisch, Volker (NIH/NCI) [C]

If I understand you correctly you would want to have the image placeholder text marked up just like the regular text? Does this mean you also want to have the images when they are included in the report marked up?

Comment entered 2017-03-20 16:10:41 by Osei-Poku, William (NIH/NCI) [C]

That is correct about the placeholder text and yes, if there is a way to mark up the images themselves too that should be fine.

Comment entered 2017-03-22 13:15:08 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated to markup the inserted/deleted image elements:

  • CDR339576: Module: InLine Markup Formatter

  • CDR380958: Module: STYLE QC Summary

This is ready for preview on DEV.

For my information: Changes are in trunk sandbox.

Comment entered 2017-04-03 11:41:50 by Osei-Poku, William (NIH/NCI) [C]

The changes appear to work for some summaries and not others. At least, it appears not to work for Patient Treatment summaries. I have a couple of markup in the following Patient Treatment summaries and none of them display in the report. CDR0000062956 and CDR0000062954. It appears to work in Patient Prevention summaries like CDR0000062825 but even in this case, it works only when you place the deletion markup around the block. It doesn't work when you place the deletion markup around just the Media ID element. I am not sure if this is the right interpretation of the problem but at least it doesn't work for all summaries.

Comment entered 2017-04-03 17:34:48 by Englisch, Volker (NIH/NCI) [C]

I found and fixed the problem that was a result of how you had entered the MediaLink vs. how I entered it. The markup should now be displayed regardless what summary. However, I do have a question: Are you expecting the markup display to also follow the different revision levels?
After denormalization and markup processing the revision level is only available to text nodes but a MediaLink might not contain any text nodes if a caption isn't displayed. If you do want this feature we have a lot more work to do in terms of filter changes and additional testing.

Comment entered 2017-04-03 17:40:43 by Osei-Poku, William (NIH/NCI) [C]

Are you expecting the markup display to also follow the different revision levels?

Not at this point or in this ticket. It is okay to not apply the revision level displays. If needed, I will bring it up in the future. Thanks!

Comment entered 2017-04-03 18:17:33 by Englisch, Volker (NIH/NCI) [C]

That sounds good. I've made the changes to the filters and this is now ready for testing again on DEV.

Comment entered 2017-04-04 12:46:04 by Englisch, Volker (NIH/NCI) [C]

Please note that OCECDR-4237 and this ticket have to be moved together because they share a modified filter.

Comment entered 2017-04-06 21:41:53 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2017-04-27 16:00:55 by Osei-Poku, William (NIH/NCI) [C]

Same as OCECDR-4237, this is ready for the next steps as far as testing is concerned.

Comment entered 2017-04-27 16:52:40 by Englisch, Volker (NIH/NCI) [C]

The two filters have been copied to QA for testing:

  • CDR339576: Module: InLine Markup Formatter

  • CDR380958: Module: STYLE QC Summary

Comment entered 2017-05-01 16:25:57 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA

Comment entered 2017-05-02 12:39:59 by Englisch, Volker (NIH/NCI) [C]

The filters have been copied to STAGE.

Comment entered 2017-05-03 11:33:22 by Osei-Poku, William (NIH/NCI) [C]

Verifed on STAGE. Thanks

Comment entered 2017-05-03 13:32:13 by Englisch, Volker (NIH/NCI) [C]

The following filters have been copied to PROD:

  • R14689: CDR339576: Module - InLine Markup Formatter

  • R14689: CDR380958: Module - STYLE QC Summary

Please verify on PROD and close this ticket.

Comment entered 2017-05-17 15:18:15 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Elapsed: 0:00:00.001313