Issue Number | 4238 |
---|---|
Summary | Markup of Media Link block does not display in RLSO QC Report |
Created | 2017-03-11 12:12:45 |
Issue Type | Improvement |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2017-03-22 13:15:20 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.204540 |
When a medial link block is marked up to be deleted, the markup does not show up in the RLSO report. This happens even if you markup the whole block. Please modify the QC report to display the changes.
Could you prepare a sample document that shows this, ~oseipokuw?
I've added three MediaLink elements to the Small Intesting Cancer Treatment HP summary on DEV (CDR62902), one without markup, one with parts of the caption marked-up and one with the entire MediaLink placed within markup. All of the marked-up text appears properly displayed.
If you look at the third image where you've marked up the entire
image block,
"Image: brain, lateral and medial, adult, anatomy" is not marked up in
the QC report. It seems to be no different from the first image where
there is no markup except that in the third image, the caption is
showing the markup. Is it possible to show the ImageID as marked up in
the QC report just as it is in XMetal?
If I understand you correctly you would want to have the image placeholder text marked up just like the regular text? Does this mean you also want to have the images when they are included in the report marked up?
That is correct about the placeholder text and yes, if there is a way to mark up the images themselves too that should be fine.
The following filters have been updated to markup the inserted/deleted image elements:
CDR339576: Module: InLine Markup Formatter
CDR380958: Module: STYLE QC Summary
This is ready for preview on DEV.
For my information: Changes are in trunk sandbox.
The changes appear to work for some summaries and not others. At least, it appears not to work for Patient Treatment summaries. I have a couple of markup in the following Patient Treatment summaries and none of them display in the report. CDR0000062956 and CDR0000062954. It appears to work in Patient Prevention summaries like CDR0000062825 but even in this case, it works only when you place the deletion markup around the block. It doesn't work when you place the deletion markup around just the Media ID element. I am not sure if this is the right interpretation of the problem but at least it doesn't work for all summaries.
I found and fixed the problem that was a result of how you had
entered the MediaLink vs. how I entered it. The markup should now be
displayed regardless what summary. However, I do have a question: Are
you expecting the markup display to also follow the different revision
levels?
After denormalization and markup processing the revision level is only
available to text nodes but a MediaLink might not contain any text nodes
if a caption isn't displayed. If you do want this feature we
have a lot more work to do in terms of filter changes and additional
testing.
Are you expecting the markup display to also follow the different revision levels?
Not at this point or in this ticket. It is okay to not apply the revision level displays. If needed, I will bring it up in the future. Thanks!
That sounds good. I've made the changes to the filters and this is now ready for testing again on DEV.
Please note that OCECDR-4237 and this ticket have to be moved together because they share a modified filter.
Verified on DEV. Thanks!
~volker Same as OCECDR-4237, this is ready for the next steps as far as testing is concerned.
The two filters have been copied to QA for testing:
CDR339576: Module: InLine Markup Formatter
CDR380958: Module: STYLE QC Summary
Verified on QA
The filters have been copied to STAGE.
Verifed on STAGE. Thanks
The following filters have been copied to PROD:
R14689: CDR339576: Module - InLine Markup Formatter
R14689: CDR380958: Module - STYLE QC Summary
Please verify on PROD and close this ticket.
Verified on PROD. Thanks!
Elapsed: 0:00:00.001313