CDR Tickets

Issue Number 4203
Summary Allow comments in table cells
Created 2016-12-12 17:39:36
Issue Type Bug
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2017-02-01 07:08:11
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.199932
Description

We want the ability to insert Comment(s) in table cells. Please modify the summaries schema to allow the Comment element within a table cell. Presently we are only able to add the Comment element within Insertion markup but we want the ability to add the Comment element without having to enclose them within Insertion tags.

Comment entered 2017-01-24 07:06:52 by Kline, Bob (NIH/NCI) [C]

Installed on DEV. I'll be curious to see how well this works (mixing Comment elements, which are generally rendered in their own block display, with inline markup). What's the use distinction between Comment elements and Note elements (which were already allowed) here?

Comment entered 2017-01-24 07:07:23 by Kline, Bob (NIH/NCI) [C]

Should this issue really have been filed as a bug report?

Comment entered 2017-01-24 16:00:08 by Englisch, Volker (NIH/NCI) [C]

While looking at the CSS for the comments in tables I'm noticing a bug. Inserting a comment itself works fine without problems. However, when trying to enter a ResponseToComment within a table the response tags aren't created at the cursor position but - it seems - inside the following inline tag (maybe). For example, on DEV using CDR62902 I'm trying to enter a ResponseToComment after the comment in row #1 of the table. The Response gets inserted within the following Emphasis tag on row #3.

Comment entered 2017-01-24 16:06:16 by Kline, Bob (NIH/NCI) [C]

: note that this ticket only specifies inserting Comment elements in table cells, not ResponseToComment elements.

Comment entered 2017-01-24 16:12:31 by Englisch, Volker (NIH/NCI) [C]

I did notice that but both, the Comment and ResponseToComment, often go hand-in-hand.

Comment entered 2017-01-26 13:30:39 by Juthe, Robin (NIH/NCI) [E]

Please allow Response To Comment elements in tables, too.

Comment entered 2017-02-01 07:08:11 by Kline, Bob (NIH/NCI) [C]

Done.

Comment entered 2017-02-02 11:50:20 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV.

Comment entered 2017-02-24 13:22:56 by Osei-Poku, William (NIH/NCI) [C]

Inserting comments in table cells on QA produces a schema validation error message (see attached).

Comment entered 2017-02-24 16:32:45 by Kline, Bob (NIH/NCI) [C]

I just looked in the deployment logs and found that because of the problem with CBIIT changing the service account password some of the postprocessing didn't get run. I'm going to have to do the Windows portion of the deployment again. Will that mess anything up for your testing?

Comment entered 2017-02-24 16:37:52 by Juthe, Robin (NIH/NCI) [E]

That shouldn't mess up anything from my perspective. Should we stay out of QA for the time being, or is that not necessary? Is this likely the same culprit for the problems I reported in OCECDR-4217?

Comment entered 2017-02-24 16:53:03 by Osei-Poku, William (NIH/NCI) [C]

Okay with me as well. It shouldn't mess up anything for me.

Comment entered 2017-02-24 16:57:11 by Kline, Bob (NIH/NCI) [C]

As long as you're aware things might not work intermittently while the deployment is running, you should be OK.

Comment entered 2017-02-24 17:01:29 by Kline, Bob (NIH/NCI) [C]

OK, the deployment logs look much healthier this time. Give things another try.

Comment entered 2017-02-24 18:54:52 by Osei-Poku, William (NIH/NCI) [C]

The Comments in table cells validation error is gone. Thanks!

Comment entered 2017-02-28 13:40:30 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA.

Attachments
File Name Posted User
comments in cell error - QA.png 2017-02-24 13:22:46 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.001449