CDR Tickets

Issue Number 4187
Summary [Summaries] Maintain italics in media doc captions
Created 2016-11-16 18:47:52
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2017-08-03 12:56:41
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.198384
Description

I've noticed that captions in HP summaries are no longer italicized but they are displaying in regular un-italicized text, which makes them hard to separate from the running text in the summary. I think that was an unintended side effect of OCECDR-4082.

It actually looks like the text gets converted from italicized to regular text during the copy/paste into Word, not in the QC report itself. I've compared this to earlier versions (the latest of which was made on November 3) and the text remained italicized through the copy/paste into Word, yet one created at 7pm on November 4 shows the problem.

Comment entered 2016-11-16 19:12:29 by Englisch, Volker (NIH/NCI) [C]

I didn't see the email. Do you want Bob to have all the fun?

Comment entered 2017-01-31 18:58:00 by Englisch, Volker (NIH/NCI) [C]

It actually looks like the text gets converted from italicized to regular text during the copy/paste into Word, not in the QC report itself.

Yes, that is correct, and every browser is behaving differently. Our favorite browser is Chrome. There are no formatting problems in Chrome, especially when the window has been resized first to a portrait format.
Copying from Firefox is the worst, tables aren't displaying properly, the font changes to Times Roman and italic font gets converted for both, table and figure captions.
IE preserves italics in tables but not in figure captions.

I'll check the filters involved and to see if a change of the filters or an upgrade to the browser or Word is to blame for the changed behavior.

Comment entered 2017-02-01 13:10:56 by Englisch, Volker (NIH/NCI) [C]

It appears that IE has problems applying the correct CSS style if it's an inherited style.
The caption text is part of a div element that's a child of another div like this:

<div style="font-style: italic">
  <div>
     Caption Text
  </div>
</div>

If I move the font styling from the parent div to the child div the pasted text preserves the style in Word. As a work-around I'll have to modify the CSS of our filter accordingly. This will work as expected:

<div>
  <div style="font-style: italic">
     Caption Text
  </div>
</div>

Obviously, this is an IE bug and IE should handle our QC report output correctly.

Comment entered 2017-02-02 13:15:46 by Englisch, Volker (NIH/NCI) [C]

The following filter has been updated in order to preserve the font-style in captions when pasting the QC report into Word:

  • CDR335169: Module: STYLE Default

This is ready for review on DEV.

Comment entered 2017-03-17 14:48:24 by Englisch, Volker (NIH/NCI) [C]

This filter change was also part of the Einstein filter changes as R14575 and is on production.

Comment entered 2017-06-14 14:56:40 by Englisch, Volker (NIH/NCI) [C]

, is it OK to close this ticket? The change was put on PROD as part of Einstein.

Comment entered 2017-06-22 17:30:37 by Juthe, Robin (NIH/NCI) [E]

This isn't working properly on PROD. The captions are italicized in the QC report in my browser, but that is lost when the report is copied/pasted into Word (before running the macro).

Comment entered 2017-06-22 17:51:58 by Englisch, Volker (NIH/NCI) [C]

I will have to visit you tomorrow and then we'll have to figure out why this is working for me but not for you. Maybe you need a new laptop. :-)

Comment entered 2017-06-28 17:20:09 by Englisch, Volker (NIH/NCI) [C]

This was working properly for patient summaries but not for HP summaries. I've made some minor changes to the following filter:

  • CDR0000339576.xml - Module: InLine Markup Formatter

This is ready for review on DEV and QA.

Comment entered 2017-07-13 13:51:39 by Juthe, Robin (NIH/NCI) [E]

Verified on DEV.

Comment entered 2017-07-18 17:29:31 by Englisch, Volker (NIH/NCI) [C]

I've updated the filter on QA and on STAGE. Please double-check before I'll move the filter changes to PROD.

Comment entered 2017-08-03 12:26:57 by Juthe, Robin (NIH/NCI) [E]

Verified on STAGE.

I don't think this is related, but in case it is, you may remember that we noticed that the images are now right-justified with the title of the image right-justified beneath them and a blue box to the left of and below the image. I suspect we'll want a separate issue to address that, but let's discuss this in our meeting today.

Comment entered 2017-08-03 12:48:02 by Englisch, Volker (NIH/NCI) [C]

I forgot about that issue but now I remember.
The image title display beneath the image is a result of the browser window size and the changes to fix this problem. Depending on how important the new issue is to everyone I can try to fix is as part of this issue. However, since the italics fix is ready to go to PROD you may instead want to create a new ticket to have the image title display modified again.

Comment entered 2017-08-03 12:52:15 by Juthe, Robin (NIH/NCI) [E]

I'll add a separate ticket. Let's promote this change.

Comment entered 2017-08-04 16:53:49 by Englisch, Volker (NIH/NCI) [C]

The following filter is on PROD:

  • R14270: Module: STYLE Default (CDR339576)

Comment entered 2017-08-04 17:13:15 by Englisch, Volker (NIH/NCI) [C]

The following filter has been copied to PROD:

  • R14858: Module: InLine Markup Formatter (CDR339576)

Please verify on PROD and close this ticket.

Comment entered 2017-08-10 13:47:45 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD.

Elapsed: 0:00:00.001337