CDR Tickets

Issue Number 4116
Summary Modify summaries QC Reports to show dictionary and audience of glossary terms
Created 2016-05-31 14:48:35
Issue Type New Feature
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2016-08-25 16:59:07
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.185192
Description

With the implementation of the new business rules for displaying definitions for glossary terms in OCECDR-3903, we want to be able to have the ability to review cases where the Dictionary and/or the Audience of a glossary term may be different from that of the Summary since we don't have the ability to review this when glossifying a summary document.

We suggest that when a user selects the option to display glossary terms at the end of the BU and RLSO reports, the dictionary and audience information for each of the terms is included in the table output. Alternatively, the information should be displayed only when the audience and dictionary information is different from that of the summary.

Comment entered 2016-06-02 13:40:43 by Juthe, Robin (NIH/NCI) [E]

It's likely this won't need to be part of a release (filter change only), but Volker will check.

Comment entered 2016-07-22 15:41:13 by Englisch, Volker (NIH/NCI) [C]

would you be able to create a new glossary term on DEV and link it to a (short) summary for testing?

Comment entered 2016-07-22 15:43:15 by Englisch, Volker (NIH/NCI) [C]

Oops, sorry, I think I wanted to add the last comment to OCECDR-4105.

Comment entered 2016-07-25 12:59:45 by Englisch, Volker (NIH/NCI) [C]

I've made some changes to the report on DEV. , could you take a look if this change is what you had in mind? If it is I'll go ahead and make the change for LOERefs as well.

Comment entered 2016-07-25 14:10:32 by Osei-Poku, William (NIH/NCI) [C]

Yes, this is exactly what we wanted. Thanks!!!
While testing, I realized that for IACT summaries, when the linked glossary term has a dictionary of Cancer.gov, the definition is not displayed. However, it displays correctly when the dictionary is Genetics.

Comment entered 2016-07-25 14:14:34 by Englisch, Volker (NIH/NCI) [C]

Thanks, William. I will take a look and finish up the report.

It's likely this won't need to be part of a release (filter change only), but Volker will check.

Volker checked and confirmed. :-)

Comment entered 2016-07-25 16:40:39 by Englisch, Volker (NIH/NCI) [C]

While testing, I realized that for IACT summaries, when the linked glossary term has a dictionary of Cancer.gov, the definition is not displayed. However, it displays correctly when the dictionary is Genetics.

The IACT summaries are a special beast. These are HP summaries but they are displaying patient glossaries. The definition text displays correctly for the patient versions, right?

If we're always displaying the patient definition regardless of the summary audience for the IACT summaries I can change the selection of the definition text.

Comment entered 2016-07-25 17:02:50 by Osei-Poku, William (NIH/NCI) [C]

The IACT summaries are a special beast. These are HP summaries but they are displaying patient glossaries. The definition text displays correctly for the patient versions, right?

That is right.

If we're always displaying the patient definition regardless of the summary audience for the IACT summaries I can change the selection of the definition text.

The IACT summaries also follow the same business rules as other summary types. So, if there are HP definitions, they will be assigned before Patient definitions. Fortunately or unfortunately the IACT summaries contain a lot more patient glossaries/definitions than HP and it is a good case for us to see exactly which definition is being displayed.

Comment entered 2016-07-25 17:55:51 by Englisch, Volker (NIH/NCI) [C]

That makes sense. I've modified the QC report to pick up the patient definition for GlossaryTerms in the absence of the HP definition.
Please let me know if you see anything else that needs to be changed.

Comment entered 2016-08-18 11:36:15 by Osei-Poku, William (NIH/NCI) [C]

This was tested as part of OCECDR-4105 on DEV.

Comment entered 2016-08-25 16:58:50 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated on QA:

  • R14183: CDR335166 - Module: Checkbox Formatter

  • R14183: CDR409593 - Copy XML for Summary Report

This is ready for review on QA.

For my information: QC_Filter_Changes branch

Comment entered 2016-09-06 17:37:41 by Osei-Poku, William (NIH/NCI) [C]

We have completed testing these changes on QA. They all look good. Thank you!

Comment entered 2016-09-07 15:35:37 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated on STAGE:

  • R14183 (QC_FC branch): CDR335166 - Module: Checkbox Formatter

  • R14183 (QC_FC branch): CDR409593 - Copy XML for Summary Report

Comment entered 2016-09-12 11:24:30 by Osei-Poku, William (NIH/NCI) [C]

Verified on STAGE.

Comment entered 2016-09-20 15:37:33 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated on PROD:

  • R14183 (QC_FC branch): CDR335166 - Module: Checkbox Formatter

  • R14183 (QC_FC branch): CDR409593 - Copy XML for Summary Report

Comment entered 2016-10-04 14:38:03 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thank you!

Elapsed: 0:00:00.001191