CDR Tickets

Issue Number 4082
Summary Modify Summaries QC reports to display media doc captions
Created 2016-04-20 16:16:26
Issue Type New Feature
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2016-08-31 16:16:34
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.182825
Description

Please modify the summaries QC reports to display captions when entered in the media docs. If captions are entered both in the Media doc and the Summary doc, display the caption in the summary document. This will affect the English and Spanish RL/SO and BU reports for HP & Patient audiences.

Comment entered 2016-07-28 14:03:37 by Kline, Bob (NIH/NCI) [C]

will speak to the other board managers and Diana to find out what their preferences are.

Comment entered 2016-08-05 15:12:22 by Englisch, Volker (NIH/NCI) [C]

If there are already samples I can see for media/summary captions please include those here. Thank you!

Comment entered 2016-08-08 16:32:13 by Osei-Poku, William (NIH/NCI) [C]

If there are already samples I can see for media/summary captions please include those here. Thank you!

On DEV:
Media: CDR0000755927
Summary: CDR0000257990

Please let me know if you want to see more samples.

Comment entered 2016-08-08 18:09:44 by Englisch, Volker (NIH/NCI) [C]

Robin Juthe will speak to the other board managers and Diana to find out what their preferences are.

Should I be working on this ticket or should I wait for the result of the discussion?

Comment entered 2016-08-09 08:46:24 by Juthe, Robin (NIH/NCI) [E]

Please hold off for right now. I'm planning to discuss this with the rest of PCIB in our next staff meeting. thanks.

Comment entered 2016-08-24 13:55:14 by Juthe, Robin (NIH/NCI) [E]

The rest of the PCIB team is fine with this change. However, for patient B/U and RLSO QC reports only, please display the caption only when the "Display images" box is checked. They do not want to see the caption at all times. Please continue to display the caption at all times in the HP summary QC reports (i.e., regardless of whether the option to display images is checked). Thanks.

Comment entered 2016-08-31 16:16:20 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated on DEV to modify the figure caption display:

  • CDR335169: Module: STYLE Default

  • CDR339576: Module: InLine Markup Formatter

This is ready for review on dev. You probably want to test all possible combination: HP, Patient, EN, ES, RS, BU, etc.

Comment entered 2016-08-31 17:29:36 by Osei-Poku, William (NIH/NCI) [C]

Tested different combinations as suggested and they all appeared to be working well. We'll do additional testing and let you know if we come across any problems.

Comment entered 2016-09-06 17:34:00 by Osei-Poku, William (NIH/NCI) [C]

Here are a two examples of cases where we have used the "UseCaption" attribute in the summary documents to control the display of caption of images in summaries. They are all in tables. In fact, several of the reformatted summaries have staging images in tables and in those cases, we do not want the captions to be displayed. It seems to me that it would be helpful to have the attribute conform to the display of the captions in the QC reports if possible.
62687
62917

Comment entered 2016-09-22 13:28:28 by Englisch, Volker (NIH/NCI) [C]

I've updated the filter to suppress the caption anytime the UseCaption = 'No' attribute has been set.

Comment entered 2016-10-13 10:46:20 by Osei-Poku, William (NIH/NCI) [C]

This looks good on DEV.

Comment entered 2016-10-14 16:55:32 by Englisch, Volker (NIH/NCI) [C]

The following two filters have been updated on QA and STAGE:

  • CDR335169: Module: STYLE Default

  • CDR339576: Module: InLine Markup Formatter

Comment entered 2016-10-20 11:20:27 by Osei-Poku, William (NIH/NCI) [C]

Verified on STAGE.

Comment entered 2016-11-04 13:06:57 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated on PROD:

  • R14270: Module: STYLE Default (CDR335169)

  • R14271: Module: InLine Markup Formatter (CDR339576)

Please verify on PROD and close this ticket.

Comment entered 2016-11-16 17:27:14 by Juthe, Robin (NIH/NCI) [E]

I've noticed that captions in HP summaries are no longer italicized but they are displaying in regular un-italicized text, which makes them hard to separate from the running text in the summary. I think that was an unintended side effect of these changes.

It actually looks like the text gets converted from italicized to regular text during the copy/paste into Word, not in the QC report itself. I've compared this to earlier versions (the latest of which was made on November 3) and the text remained italicized through the copy/paste into Word, yet one created at 7pm on November 4 shows the problem.

Comment entered 2016-11-16 17:49:13 by Englisch, Volker (NIH/NCI) [C]

I suggest creating a new - release independent - ticket at this point since the caption changes are already on PROD.

Comment entered 2016-11-16 18:48:12 by Juthe, Robin (NIH/NCI) [E]

Done! I've created OCECDR-4187. Thanks.

Comment entered 2017-01-31 12:06:24 by Englisch, Volker (NIH/NCI) [C]

If I follow the comments on this ticket correctly it can be closed, right?

Comment entered 2017-02-02 12:48:01 by Juthe, Robin (NIH/NCI) [E]

That's right! Closing it now.

Elapsed: 0:00:00.001278