| Issue Number | 4037 |
|---|---|
| Summary | Please remove gray shading from reports controlled by cdrcgi.Page and cdrcgi.Report classes |
| Created | 2016-03-01 10:55:10 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2016-03-03 11:40:34 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.179862 |
The definitions are difficult to read with the gray background. Margaret would like to change the background to white. Thanks.
Isn't there another ticket in the works which will deal with this issue more generally?
I think we do want to review all of the reports and remove the gray from those that we print often and/or contain a lot of text. However, is this shading handled in one place for all reports (part of the new report class?) or do we need to tell you specifically which reports should have the gray background removed? I put this ticket in because this is the highest priority one to get fixed. If the shading is handled in one place that affects all of the reports with the newer class, then I can revise this ticket to be more general rather than tell you them one by one.
Well, it would be misleading to say that row shading is handled in one place for all reports, because that wouldn't be true for some of the older reports which were created before we wrote the new classes for report generation. It is generally true however, at least for newer reports and those reports which have been rewritten to take advantage of the new classes. It would be unfortunate if we were to modify individual reports one by one, because then changes that you want us to make across the board to the report display would not be honored by the hand-modified reports unless we were to go back and find them and remove the customized display rules. I would strongly recommend that unless you have a reason to have this report look different from the standard report (which seems unlikely – would users really want the GTC by English Definition Status Report to look different from the GTC by Spanish Definition Status Report, for example?) it would be best to have us modify the style rules for all of the reports controlled by the cdrcgi.Page and cdrcgi.Report classes.
I agree - let's modify the style rules for all of the reports in the newer class to remove the gray background. I will revise the title of the ticket. Thanks.
Is this change for the data rows only, or for the column headers as well? Any other changes while we're at it?
Try your favorite reports on DEV to see how they look now.
This is much better - thanks. Could you please remove the dark background (gray and red) from the column/row headers as well? It's still a lot of extra ink when printed. Thanks again.
Done. Give it another try.
Looks good! Thank you.
Verified on QA.
(Note: There's a very helpful comment from Bob about how to identify which reports are written in this class in the following issue: OCECDR-3986.)
Verified several reports on PROD.
Elapsed: 0:00:00.001549