CDR Tickets

This would be handled by the publishing control document, which we can update without the assistance of CBIIT.

This would be handled by the publishing control document

This is not entirely correct. The regular publishing jobs are using SQL queries from the publishing control document in order to select the document to be published. Those queries can be updated without the assistance of CBIIT.
For some task, however, namely the Hotfix publishing job, the document IDs aren't supplied as the result of a query but are entered individually. Preventing modules from being (accidentally) published via a Hotfix publishing job or a Republish job requires changes to our publishing system and this needs to be part of a release.

The publishing control document has been updated on DEV:

• R13834: Primary.xml

The following program has been modified to prevent the publishing of modules:

• RepublishDocs.py

I will have to discuss with Bob if we want to fail creating a job if a module has been included in the list of CDR-IDs or if we ignore the module and publish the remaining documents provided.

I will discuss with Bob if the changes for the Hotfix-Export should be made in the server or elsewhere.

The SQL queries in the server (line 655 + 665 in CdrPublish.cpp will need to be modified to include the following exclusion:

...
AND v.id NOT IN (SELECT doc_id 
                   FROM query_term i
                  WHERE i.doc_id = v.id
                    AND path = '/Summary/@ModuleOnly'
                )

I've modified the program publishing.py. This script already addressed the problem of audio recordings accidentally getting published as a hot-fix. I extended it to exclude modules:

• R13878: publishing.py

This is ready for testing on DEV.

The following program has been modified to prevent the publishing of modules as part of the republish interface:

• R13821: RepublishDocs.py

Hi Volker,

I just created a new module on DEV for testing but I am not authorized to publish it. Could you please either publish it or give me permission to do so? I promise not to break anything!
CDR778230 - Robin's Test Module

Thanks!

It looks like the sample document Robin mentioned above is now publishable. In case we need more modules for testing, I have created two new modules on DEV for additional testing. I also wanted to find out if for test purposes we need to vary the modules attributes? That is, currently we have all of them set as AvailableAsModule ="Yes" and ModuleOnly ="Yes". Is that okay? Here are the two new modules:
CDR0000778286
CDR0000778287

Where do you see it published? I'm looking on Gatekeeper DEV and don't see the document.

Sorry for succeeding in confusing you. I said "publishable" :-). I assumed that Robin was unable to make the document publishable. I didn't think she meant "publishing" it to Cancer.gov.

Yes, you did. I didn't read carefully enough.

If you want to do additional testing on DEV that is OK but I hadn't planned additional testing. Let me know if you'd like to do additional testing on DEV. Otherwise you may want to create those test modules on QA instead.

I also wanted to find out if for test purposes we need to vary the modules attributes?

No, the attributes are fine as is.

In that case we will test on QA at the appropriate time. Thanks!

I had changes not yet versioned in my sandbox:

• R13948: RepublishDocs.py

Here are two modules on QA for test publishing:

CDR0000779882
CDR0000779883

Test #1 - Success
The new modules were not picked up for publishing as part of the nightly publishing job.

Test #2 - Success
Attempt to hot-fix summary modules failed.

Test #3 - Success
Attempt to Re-publish summary modules failed.

I don't want to submit a publishing job because this will slow down the system to a crawl. We should let the weekend publishing job not pick up these documents and confirm on Monday.

The two modules were not prat of the weekend publishing job.

Can we close this ticket?

Has it been verified on PROD? I don't think we've published any new modules since May 13. We can close it for now and reopen if it becomes a problem, though.

We tested it on all other tiers. Of course, we don't really want to create a "fake" module just to test that it doesn't get published.
I agree, we should close it for now and reopen if needed.