CDR Tickets

Issue Number 3867
Summary PCIB Statistics Report
Created 2015-01-29 15:42:47
Issue Type Improvement
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2016-01-29 14:58:34
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.146003
Description

The PCIB statistics report is run as a scheduled job for Margaret. We created a web interface to allow this report to be run for different time periods than the default monthly run. CIAT voiced interest to being able to run this report as well and we want to ensure that the report run from the web sends a report to the logged on user while the automated job is submitted to Margaret.

We also want to restrict the job to be run only by users of the "ICRDB Statistics Notification" group.

Comment entered 2016-01-29 14:04:26 by Englisch, Volker (NIH/NCI) [C]

I've modified the report as well as the web form to allow running the report for a specified time frame and sending it to a specified email address instead of sending the report to the default list of recipients.
The report will still be submitted to the default list of recipients if the email address field is left empty.
The following files have been updated:

  • RunPCIBStatReport.py

  • PCIBStatReport.py (renamed from ICRDBStatReport.py

The description of this ticket mentions to restrict the job to be run only by users of the ICRDB Statistics Notification group but I'm wondering if we really want to limit this report to only be run by the recipients of that group (currently Margaret, William, and Volker)

Comment entered 2016-01-29 14:58:34 by Englisch, Volker (NIH/NCI) [C]

Ready for testing on DEV.

Comment entered 2016-01-29 15:00:12 by Beckwith, Margaret (NIH/NCI) [E]

I don't think it needs to be restricted as long as people put their email address in so that the whole group doesn't get it every time anyone runs it. That was why we kept the initial group small. Can the person's email address be filled in by default?

Comment entered 2016-01-29 15:07:50 by Englisch, Volker (NIH/NCI) [C]

Yes, that's how it is currently setup: If the person has an email address listed in the CDR the form with populate the field with the user's email address.

Comment entered 2016-01-29 15:53:57 by Beckwith, Margaret (NIH/NCI) [E]

Then I think it is fine to not restrict it.

Comment entered 2016-03-08 15:50:03 by Juthe, Robin (NIH/NCI) [E]

Volker, just noticed a couple of small things with this report.

1) Could you please change the name of this report in the e-mailed output from PCIB Status Report to PCIB Statistics Report? It says Statistics in the report menu but Status when you run it.

2) In the text that appears after your submit the report request, it should say "The report has been sent to you by email." (it says "send" now)

3) Should we remove the "(MB)" after the report name in the menu now that we're making it available to everyone?

Thanks!

Comment entered 2016-03-21 14:51:40 by Englisch, Volker (NIH/NCI) [C]

"The report has been sent to you by email." (it says "send" now)

Just yesterday, I was discussing the importance of using proper grammar with my son. Please don't tell him. :-)

The following programs have been updated on DEV including the latest modifications:

  • R13789: BoardManagers.py (in cgi-bin/cdr)

  • R13791: RunPCIBStatReport.py (in cgi-bin/cdr)

  • R13792: PCIBStatsReport.py (in /cdr/publishing)

This is ready for review.

Comment entered 2016-03-24 11:53:24 by Juthe, Robin (NIH/NCI) [E]

Verified on DEV. Thank you!

Comment entered 2016-03-24 12:28:56 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks. Just a minor question. Can you put multiple emails in the email field so that the report goes to multiple people?

Comment entered 2016-03-24 12:31:22 by Englisch, Volker (NIH/NCI) [C]

I don't think I've ever tried that. I'll have to check what the code is doing.

Comment entered 2016-03-24 12:59:14 by Osei-Poku, William (NIH/NCI) [C]

Don't bother, we are able to do that with other reports so I thought I would ask. I don't think this is a problem.

Comment entered 2016-04-01 14:10:19 by Juthe, Robin (NIH/NCI) [E]

Verified on QA.

Comment entered 2016-05-23 16:32:26 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD.

Elapsed: 0:00:00.001827