| Issue Number | 3798 |
|---|---|
| Summary | Custom validation rule for TranslationOf element |
| Created | 2014-09-03 12:00:41 |
| Issue Type | New Feature |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | alan |
| Status | Closed |
| Resolved | 2015-01-29 13:50:31 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.137271 |
We would like a new custom validation rule implemented on the TranslationOf element of the summary schema. This will prevent the occasional user error of failing to link to the correct summary and consequently creating a toggle error on Cancer.gov. The rule should be:
1. When the TranslationOf element is selected for a Spanish HP summary, the summary to be retrieved should be an English HP summary and…
2. When the TranslationOf element is selected for a Spanish Patient summary, the summary to be retrieved should be an English Patient summary.
We added a custom rule in March 2014 that validates that the languages match. I'm assuming that works fine, so I'll just add a similar rule with similar logic to ensure that the SummaryAudience values also match.
Actually, the rule we added in March isn't exactly what we need to match for languages here. I'll therefore be adding two new validation tests, one for language and one for audience.
I believe that I have this working on DEV. It can be tested there.
There was no change to software, just to the SummarySchema.xml file.
This appears to be working on DEV. Thanks! I will test with a few more documents and sign off on DEV.
Verified on DEV.
I have verified that the modified schema that implements the new rules has no other changes from the Summary schema in production. We can install the new schema into production without requiring CBIIT assistance.
I have removed the CDR-Awaiting Release label.
The new schema is in the Ampere branch in subversion.
This change does not appear to be on QA yet. A search retrieves both HP and Patient summaries.
I'll check it out.
Sorry it took me this long to get to this.
I don't remember whether I updated the schemas before or after you did your test on QA (which I had not done in the original QA deployment), but I must have done it after your test. The updated schema fixes the problem.
To test again, I called up the Nausea and Vomiting Spanish document 256629 in XMetal and ran schema validation. That worked fine. Then I modified the TranslationOf element cdr:ref to point back to itself, 256629, i.e., a Spanish language document declared as the translation of a Spanish language document. That failed validation, as it should.
So I'm thinking that everything is okay here.
Please re-test.
Thanks.
I think this had been working all along. I had forgotten about how it is supposed to work. I thought that it should prevent me from retrieving summaries that had mismatched audience but instead, it is let's you see both audiences however, when you choose the incorrect audience, it displays a validation error message. Sorry about this, Alan. I have tested it now and it is working correctly.
Verified on QA.
Verified on Stage
Verified on PROD.
Elapsed: 0:00:00.001542