| Issue Number | 3761 |
|---|---|
| Summary | Modify QC report to identify which doc types are not represented in the filters dictionary |
| Created | 2014-05-01 15:23:15 |
| Issue Type | Improvement |
| Submitted By | Kline, Bob (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2014-05-02 15:10:53 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.124274 |
On line 1761 and following, QcReport.py is detecting the condition that a document type has been specified for which we don't have QC report filters, but it's not identifying which document types those are. Please modify the code to log the document type.
While you're there, please also modify the call to cdrcgi.sendPage to leave the argument as a Unicode string, since sendPage() takes care of the conversion to utf-8 (and is logging the passing of a byte-string in debug.log).
... but it's not identifying which document types those are
The document for which we don't have a filter set specified is loaded and displayed (well, sort of). Isn't that good enough for identifying the problem or are you asking to also write some information to the logs?
The report has been updated as requested and is ready for review on DEV:
R12626: QcReport.py
Excellent! Do you think it might be worth while to include the user ID in the log message? That way, we'll be in a better position to find out if there's a QC report we should be supporting with a real filter set (because we'll be able to ask the user if the requests were mistakes or intentional).
Do you think it might be worth while to include the user ID in the log message?
How can I say No when you already gave a good reason? :-)
R12627: QcReport.py
Ausgezeichnet! I'm closing, even though it's not on PROD yet. It'll migrate with the next release.
Danke sehr!
Elapsed: 0:00:00.001252