CDR Tickets

Issue Number 3557
Summary [Glossary] Modify vendor filter to suppress Related External Ref without definition
Created 2012-10-31 14:13:11
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2013-01-16 12:03:10
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107885
Description

BZISSUE::5254
BZDATETIME::2012-10-31 14:13:11
BZCREATOR::William Osei-Poku
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

Two Glossary documents failed publishing because Spanish RelatedExternalRef elements were added without Spanish definitions being present in the Concept documents. Please modify the vendor filter to suppress RelatedExternalRef elements when there are no matching definitions in the Concept documents. Also, report a warning message in the publishing report whenever this happens so that we can fix it

Comment entered 2012-11-27 13:57:54 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-11-27 13:57:54
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

The filter has been updated to drop a RelatedExternalRef or RelatedSummaryRef element to be used for Spanish definitions if the SpanishTermDefinition doesn't exist in the document:
CDR315588 - Module: Vendor Cleanup Templates

This is ready for testing on MAHLER.

Comment entered 2012-11-27 15:39:30 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2012-11-27 15:39:30
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::2

(In reply to comment #1)
>
> This is ready for testing on MAHLER.

It seems to be working. However, what I get on Mahler is a python script error in pub preview whenever the translated definition is absent from the concept document. When the translated definition is present, I am able to get pub preview.

Comment entered 2012-11-28 11:22:48 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-11-28 11:22:48
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

From the error message it looks like the same problem, however, now it's affecting the MediaLink element. Gatekeeper will not be able to extract the Media document for the Spanish definition when the Spanish TermDefinition doesn't exist.

I suggest to remove the Spanish MediaLink element as well.

Comment entered 2012-11-28 18:01:38 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2012-11-28 18:01:38
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::4

(In reply to comment #3)
> From the error message it looks like the same problem, however, now it's
> affecting the MediaLink element. Gatekeeper will not be able to extract the
> Media document for the Spanish definition when the Spanish TermDefinition
> doesn't exist.
>
> I suggest to remove the Spanish MediaLink element as well.

I did and they seem to be working fine. Please promote changes to Bach.

Comment entered 2012-11-28 18:25:04 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-11-28 18:25:04
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

(In reply to comment #4)
> I suggest to remove the Spanish MediaLink element as well.

My suggestion was rather to have the filter remove the MediaLink unless you think this would not be necessary.

Comment entered 2012-11-28 22:04:45 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2012-11-28 22:04:45
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::6

(In reply to comment #5)
> (In reply to comment #4)
> > I suggest to remove the Spanish MediaLink element as well.
>
> My suggestion was rather to have the filter remove the MediaLink unless you
> think this would not be necessary.

Sorry. I misunderstood that. Let's go with handling it in the filter. I think your suggestion is a better solution.

Comment entered 2012-12-12 15:20:15 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-12-12 15:20:15
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

I've updated the filter to perform the same action and drop the MediaLink element if the Spanish definition doesn't exist.
CDR315588 - Module: Vendor Cleanup Templates

This is ready for testing on MAHLER.

Comment entered 2012-12-12 15:42:57 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2012-12-12 15:42:57
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::8

(In reply to comment #7)
> This is ready for testing on MAHLER.

Verified on Mahler. Pub preview did come up fine for two terms that I updated to duplicate the problem. Please promote to Bach.

Comment entered 2012-12-21 13:37:09 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-12-21 13:37:09
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9

I ran diff reports on FRANCK for most of our document types (CTGovProtocol, InScopeProtocol, Summary, Term, GlossaryTerm, DrugInfoSummaries) and found one problem that I fixed (Spanish MediaLink elements were stripped from Summaries).

The following filter has been copied to FRANCK and BACH:
CDR315588 - Module: Vendor Cleanup Templates - R10970

I will double-check the vendor output after tonight's publishing job to confirm that everything is still working correctly.

Comment entered 2013-01-15 17:35:40 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2013-01-15 17:35:40
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10

(In reply to comment #9)

> I will double-check the vendor output after tonight's publishing job to confirm
> that everything is still working correctly.

As it turned out not everything was running correctly. However, the problems have now been fixed through OCECDR-3576.

Please close this bug.

Comment entered 2013-01-16 12:03:10 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2013-01-16 12:03:10
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::11

(In reply to comment #10)
> (In reply to comment #9)

>
> Please close this bug.

Bug closed.

Elapsed: 0:00:00.002437