CDR Tickets

Issue Number 3553
Summary [Summaries] Remove Blocked Summaries from PDQ Board Members and Topics Report
Created 2012-10-24 17:44:09
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2013-01-03 12:18:53
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107881
Description

BZISSUE::5250
BZDATETIME::2012-10-24 17:44:09
BZCREATOR::Robin Juthe
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

We would like to remove all blocked summaries from appearing on the PDQ Board Members and Topics Report.

Comment entered 2012-10-24 17:57:04 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-10-24 17:57:04
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

I am guessing you would like to have those removed from both versions of the report, the report by member and the report by topic, right?

Comment entered 2012-10-24 17:58:27 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2012-10-24 17:58:27
BZCOMMENTOR::Robin Juthe
BZCOMMENT::2

(In reply to comment #1)
> I am guessing you would like to have those removed from both versions of the
> report, the report by member and the report by topic, right?

That's right. Thanks!

Comment entered 2012-11-26 18:08:46 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-11-26 18:08:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

I have made the changes to the output but since the interface looks so bad I've also changed the initial page a little.

I will still align the fields "Order By" and "Display CDR-ID" but wanted to check first if this change would be OK in principle.

The report is ready to be checked on MAHLER.

Comment entered 2012-11-27 10:13:36 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2012-11-27 10:13:36
BZCOMMENTOR::Robin Juthe
BZCOMMENT::4

(In reply to comment #3)
> I have made the changes to the output but since the interface looks so bad I've
> also changed the initial page a little.
> I will still align the fields "Order By" and "Display CDR-ID" but wanted to
> check first if this change would be OK in principle.
> The report is ready to be checked on MAHLER.

Yes, I agree - the interface could use some work. What you've done, plus fixing the alignment of those two fields, is definitely an improvement. Thanks.

I verifed that blocked summaries are being suppressed from the report output.

This is a picky thing, but I noticed when you order the report by Board member, the Board member names show up in a different font than the summaries.

Comment entered 2012-11-27 10:24:02 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-11-27 10:24:02
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

> I noticed when you order the report by Board member,
> the Board member names show up in a different font than the summaries.

Let me guess: You are using IE as your browser?
I'm using FF and the font is the same. I'll take a look to see what can be done about the difference.
Looks like Chrome agrees with IE on this one.

Comment entered 2012-11-27 10:27:36 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2012-11-27 10:27:36
BZCOMMENTOR::Robin Juthe
BZCOMMENT::6

I am using IE. If it's an easy fix, great, but if not, don't worry about it. It's an internal report so it isn't worth spending a lot of time to resolve it.

Comment entered 2012-11-27 15:42:05 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-11-27 15:42:05
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

The font and the initial page have been modified. Please have a look on MAHLER and let me know if this looks OK.

Comment entered 2012-11-29 14:02:33 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2012-11-29 14:02:33
BZCOMMENTOR::Robin Juthe
BZCOMMENT::8

(In reply to comment #7)
> The font and the initial page have been modified. Please have a look on MAHLER
> and let me know if this looks OK.

This looks good, but I noticed another tiny thing.

When you select to run the report including CDR IDs and sorted by topic, the summary titles are not bolded but I think they should be.

Comment entered 2012-12-04 16:23:11 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-12-04 16:23:11
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9

(In reply to comment #8)
> This looks good, but I noticed another tiny thing.

What you saw was just the tip of the iceberg. :-)

I made some additional changes because the HTML code created wasn't clean.
Please have another look on MAHLER.

Comment entered 2012-12-13 14:10:00 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-12-13 14:10:00
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10

The display problem Robin reported only showed up in IE when running without the compatibility mode.
I've adjusted some CSS settings and I believe the problem is now fixed for IE as well.

Please take another look on MAHLER.

Comment entered 2012-12-20 14:37:44 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2012-12-20 14:37:44
BZCOMMENTOR::Robin Juthe
BZCOMMENT::11

This looks good on Mahler. Please promote to Bach.

Comment entered 2012-12-20 16:02:19 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2012-12-20 16:02:19
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12

The following program has been copied to FRANCK and BACH:
PdqBoards.py - R10970

Please verify on BACH and close this bug.

Comment entered 2013-01-03 12:18:53 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2013-01-03 12:18:53
BZCOMMENTOR::Robin Juthe
BZCOMMENT::13

(In reply to comment #12)
> The following program has been copied to FRANCK and BACH:
> PdqBoards.py - R10970
> Please verify on BACH and close this bug.

Verified on Bach. Closing issue.

Elapsed: 0:00:00.001769