| Issue Number | 3549 |
|---|---|
| Summary | [Summaries] Add Assistant Info to Renewal Correspondence Mailers |
| Created | 2012-10-17 17:34:28 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2013-09-03 11:59:22 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.107877 |
BZISSUE::5246
BZDATETIME::2012-10-17 17:34:28
BZCREATOR::Robin Juthe
BZASSIGNEE::Bob Kline
BZQACONTACT::William Osei-Poku
We would like to add the Board Member Assistant Information to the block of information to be verified/updated on page 2 of the following mailers:
-Editorial Board Renewal Letter
-Editorial Board Editor-in-Chief Renewal Letter
On page 2 of each of these mailers, there's currently a section which reads, "For our records, please confirm that the following information is correct or make any necessary changes." This is followed by a block of information about the Board member, including his/her title, address, phone number, etc.
We would like to add a second, smaller block of information about his/her assistant. This should include the following fields (from the Board Member Information Document):
Assistant Name:
Assistant Phone Number:
Assistant Fax:
Assistant E-mail:
Please add at least one empty row in between the blocks of information about the Board member and his/her assistant.
I'm putting this in as a P7.
Thanks!
BZDATETIME::2013-05-09 18:05:04
BZCOMMENTOR::Robin Juthe
BZCOMMENT::1
Revising priority after the discussion in today's CDR meeting.
This will involve getting more information from the CDR documents than we already have, and modifying the RTF generation code to include this new information.
Well, I thought I had posted this comment, but I guess JIRA thought it had been too long since my last action, and instead of saying "You need to log in again" it just put up a spinning GIF icon which never went away. Here's what I wrote:
Do you really need the label for the assistant's phone number to be as long as it is? If I leave the tab settings where they are, all of the assistant labels will overshoot the tab stop for the values. If I move the second tab stop to accommodate the longest value, the address string for the board member is likely to wrap around under the labels. One option is to have a different second tab setting for the assistant lines. Another thing we can do is shorten the new labels:
Asst Name:
Asst Phone:
Asst Fax:
Asst Email:
How shall I proceed?
Please use the abbreviated labels that you proposed. Thanks!
Modifications implemented on DEV. I used E-mail instead of Email in the shortened label, to match the block for the board member above.
Files affected:
r12001 Mailers\BoardMemberMailer.py
r12001 Mailers\include\ed-ec-renewal.rtf
r12001 Mailers\include\ed-renewal.rtf
Adding a comment from the discussion in the last status meeting:
I have reviewed this in DEV. It looks good, except that some lines of text (such as the long name of an institution) are wrapping onto a new line and are not indented.
The mailers have been rewritten to use tables instead of tabbed indents (the overwrapping was occurring in the existing portion of the contact information, not the new block for the assistant info, so I replaced the approach for both blocks). Ready for review on DEV.
These mailers are also no longer working. I'm getting the same message Margaret reported in OCECDR-3508 about a message to save the document.
We figured out that it works in Firefox (IE is broken).
Thanks for the tip. Verified on DEV.
Adding Sharon's comment: The correspondence mailers look fine to me although I do not know exactly what Robin requested. It is the correct BIG thank you text and the addition of assistant information to the fax back form is clear. That the fax back information is in a table format should not be a problem as we wouldn’t typically have to edit this form before sending.
Verified on QA.
Verified in production.
Elapsed: 0:00:00.001693