CDR Tickets

Issue Number 3420
Summary [Summaries] Summary Frag Refs to Tables in QC Reports
Created 2011-09-29 16:37:56
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-12-15 11:50:51
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107748
Description

BZISSUE::5114
BZDATETIME::2011-09-29 16:37:56
BZCREATOR::Robin Juthe
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

Summary Fragment Refs that link to tables are not working in RLSO or B/U QC reports (the links don't take you anywhere). The links work fine in PubPreview so they do seem to have been entered correctly.

Examples: There are several summary frag refs to tables in CDR552637.

Comment entered 2011-09-30 13:51:03 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-30 13:51:03
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

I found the problem which appears to exist since the start of the CDR.

Would you happen to know about a sample like this on MAHLER? If not I will have to create one.

Comment entered 2011-09-30 18:44:04 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-30 18:44:04
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

I've fixed the problem on MAHLER and you can already test that you can now link to SummaryRefs in the QC reports.

However, I would like to look at this a little bit more because these tables were written a long time ago and I'd like to be able to remove some of the older table formatting and replace this with CSS styles.
The two filters that are affected by these changes are:
CDR335519 - Module: Table Formatter
CDR335169 - Module: STYLE Default

Comment entered 2011-11-18 16:00:21 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-11-18 16:00:21
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

(In reply to comment #2)
> I would like to look at this a little bit more because these tables
> were written a long time ago and I'd like to be able to remove some of the
> older table formatting and replace this with CSS styles.

Since there is a lot going on at the moment I'm thinking it may make sense to finish up this task and create a new, lower priority, task for the modifications to the tables. So I'm marking this as fixed for now.

Please review on MAHLER.

Comment entered 2011-11-23 14:26:35 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-11-23 14:26:35
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

The following filters have been up dated on MAHLER:
CDR335519 - Module: Table Formatter - R10267
CDR335169 - Module: STYLE Default - R10267

This is ready for review on MAHLER.

Please pay close attention to the display of tables in summaries since the formatting of these has been converted to CSS where possible.

Comment entered 2011-12-02 10:55:27 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-12-02 10:55:27
BZCOMMENTOR::Robin Juthe
BZCOMMENT::5

(In reply to comment #4)
> The following filters have been up dated on MAHLER:
> CDR335519 - Module: Table Formatter - R10267
> CDR335169 - Module: STYLE Default - R10267
> This is ready for review on MAHLER.

This looks good on Mahler. Links are working properly. Thanks!

> Please pay close attention to the display of tables in summaries since the
> formatting of these has been converted to CSS where possible.

The table changes seem very minor, which is good. I noticed slightly more space between the table title & the table itself and between footnotes, lines around images and media doc titles, and darker links separating cells within a table, but I had to view them side by side to see the differences. I don't find any problems.

Comment entered 2011-12-07 10:45:36 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-12-07 10:45:36
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

The following filters have been copied to FRANCK and BACH:
CDR335519 - Module: Table Formatter - R10267
CDR335169 - Module: STYLE Default - R10267

Please verify on BACH and close this bug.

Comment entered 2011-12-08 12:30:50 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-12-08 12:30:50
BZCOMMENTOR::Robin Juthe
BZCOMMENT::7

(In reply to comment #6)
> The following filters have been copied to FRANCK and BACH:
> CDR335519 - Module: Table Formatter - R10267
> CDR335169 - Module: STYLE Default - R10267
> Please verify on BACH and close this bug.

Verified on BACH. I will close issue once I notify Bd Mgrs.

Comment entered 2011-12-15 11:50:51 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-12-15 11:50:51
BZCOMMENTOR::Robin Juthe
BZCOMMENT::8

I've notified everyone. Closing issue.

Elapsed: 0:00:00.001722