CDR Tickets

Issue Number 3390
Summary [Media] Audio player JS files not accessible in CDR Publish-Preview
Created 2011-07-12 11:25:10
Issue Type Bug
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-08-09 17:27:45
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107718
Description

BZISSUE::5083
BZDATETIME::2011-07-12 11:25:10
BZCREATOR::Volker Englisch
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

This task has been assigned to me by Blair in SharePoint for Cancer.gov 6.2.

----------------------------------------------------------------------------

The wcmsAudio.js file is referenced in the returned pub-preview HTML with a relative path because of a desire to not hard-code the /CDRPreviewWS URL.

This can be changed, however the JS file internally references speaker.swf using a server relative path (built on the fly). This cannot be changed to an absolute URL because of the need to reference the version associated with a given version of publish preview.

Possible resolutions:
For wcmsAudio.js
1. Rewrite the reference to the JS in CDR code.
2. Change to a server-relative path and require the code to always be
deployed to /CDRPreviewWS. (Better of the two.)

For Speaker.swf
1. Is it possible to host a copy of speaker.swf on the CDR server?

Comment entered 2011-07-13 16:16:41 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-07-13 16:16:41
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

The publish preview report has been modified to pick up the audio file from the local CDR server. We have three files from Cancer.gov that are now stored locally in order to display the speaker icon and play the audio:
/Inetpub/wwwroot/cgi-bin/cdr/images/audio-icon.gif
/Inetpub/wwwroot/cgi-bin/cdr/common/wcmsAudio.js
/Inetpub/wwwroot/cgi-bin/cdr/common/speaker.swf

If any of these files will be modified on Cancer.gov they should be updated on our CDR servers as well.

This is ready for review on FRANCK and MAHLER.

Comment entered 2011-07-13 16:18:06 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2011-07-13 16:18:06
BZCOMMENTOR::Bob Kline
BZCOMMENT::2

Does William know what he needs to do in order to test this?

Comment entered 2011-07-14 09:57:10 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-07-14 09:57:10
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::3

(In reply to comment #2)
> Does William know what he needs to do in order to test this?

I launched pub preview for a few terms that had the audio docs and listened to them. They all sounded/worked well. Would that be all?

Comment entered 2011-07-14 10:09:23 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-07-14 10:09:23
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

You may also want to check a few DrugInfos and checking a few of the links in other document types (i.e. Summaries) would be a good idea as a sanity check.

One additional thing you might want to try is the following: Create a new audio file and link to it, than see (better yet: hear) if this audio file is being displayed.
This would mimic the situation in which a new media document that's not published yet is being reviewed. You should be able to review a document that's stored on the current system.

Is the audio being displayed inline or does a window open to display the audio for you?

Comment entered 2011-07-14 11:41:43 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-07-14 11:41:43
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::5

(In reply to comment #4)
> You may also want to check a few DrugInfos and checking a few of the links in
> other document types (i.e. Summaries) would be a good idea as a sanity check.
>
The links seem to be working fine. Did you have any particular links in mind? Or just test any links in pub preview (which is what I did)

> One additional thing you might want to try is the following: Create a new
> audio file and link to it, than see (better yet: hear) if this audio file is
> being displayed.
> This would mimic the situation in which a new media document that's not
> published yet is being reviewed. You should be able to review a document
> that's stored on the current system.

Done. Worked fine.

>
> Is the audio being displayed inline or does a window open to display the audio
> for you?

It opens inline.

Comment entered 2011-07-14 15:14:10 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-07-14 15:14:10
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::6

I tried to test the DIS but when I added the MediaLink to the document, I was not able to link due to permission error. I updated the linking table to allow the link and I am now able to link the media docs but I get the following error when I try to launch pub preview

"CDRPreview web service error: The 'SoundEncoding' element is not declared.Validation error occurred when validating the instance document.,5,5
"

Comment entered 2011-07-15 16:58:36 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-07-15 16:58:36
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

The reason for this error is probably that you did the test on MAHLER which is running the PP report against GatekeeperGK but this system isn't using the new code yet.
At this point I'm not certain if and when GatekeeperGK will be used as our test system again so I will have to change the gatekeeper host for our development machine.

Comment entered 2011-07-17 23:30:04 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-07-17 23:30:04
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

The following files have been copied to BACH:
/Inetpub/wwwroot/cgi-bin/cdr/images/audio-icon.gif
/Inetpub/wwwroot/cgi-bin/cdr/common/wcmsAudio.js
/Inetpub/wwwroot/cgi-bin/cdr/common/speaker.swf

PublishPreview.py - R10120
cdr2gk.py - R10119

Comment entered 2011-07-20 18:41:11 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-07-20 18:41:11
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9

All of the changes are in production since Sunday night.

After we've gone through Friday's regular weekly publishing job without problems we should probably be able to close these issues.

Comment entered 2011-07-27 18:06:39 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-07-27 18:06:39
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10

There are still a few PP report issues. However, these are Gatekeeper rather than CDR issues.

Should I keep this bug open until the other issues have been resolved?

Comment entered 2011-08-09 17:27:45 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-09 17:27:45
BZCOMMENTOR::Volker Englisch
BZCOMMENT::11

The audio works fine in publish preview.

Closing issue.

Elapsed: 0:00:00.001747