CDR Tickets

Issue Number 3296
Summary [Summaries] CSS/Template changes to add Govt Employee Element to PDQ Board Member Docs
Created 2011-01-13 14:35:24
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-03-17 11:54:22
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107624
Description

BZISSUE::4986
BZDATETIME::2011-01-13 14:35:24
BZCREATOR::Robin Juthe
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

This issue depends on OCECDR-3295 which is the issue to add a new element to the schema of Board Member Information Documents in order to record government employee status for each Board member.

Comment entered 2011-01-13 17:07:03 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-01-13 17:07:03
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

The CSS has been updated, the template has been modified:
PDQBoardMemberInfo.css
PDQBoardMemberInfo_structure.css
PDQBoardMemberInfo.xml

I've set the default value to 'Unknown' in the template.
Please let me know if we want to set this element to a different default value.

This is ready for review on MAHLER.

Comment entered 2011-01-13 17:27:42 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-01-13 17:27:42
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::2

(In reply to comment #1)
> The CSS has been updated, the template has been modified:
> PDQBoardMemberInfo.css
> PDQBoardMemberInfo_structure.css
> PDQBoardMemberInfo.xml
>
> I've set the default value to 'Unknown' in the template.
> Please let me know if we want to set this element to a different default value.
>
> This is ready for review on MAHLER.

Looks fine. The default template automatically populates the "Unknown" value. I thought it would be nice to also have the same value populated when the element is added manually from the elements list. On the other hand, since Bob is going to populate the values globally, it may not be necessary.

Please promote to Bach.

Comment entered 2011-01-13 17:30:24 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-01-13 17:30:24
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

Since it's a mandatory element you won't be able to delete it and therefore it's not necessary to manually add it.

I will hold the promotion to BACH until the element has been populated for the existing documents.

Comment entered 2011-02-22 14:23:36 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-02-22 14:23:36
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::4

Could you install this change on Franck? Bob already installed the schema on Franck (OCECDR-3295).

Comment entered 2011-02-22 14:58:25 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-22 14:58:25
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

The CSS has been copied to FRANCK:
PDQBoardMemberInfo.css
PDQBoardMemberInfo_structure.css
PDQBoardMemberInfo.xml

Comment entered 2011-02-22 15:14:10 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-22 15:14:10
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

Based on the information in OCECDR-3295 I have moved the GovernmentEmployee element to appear after the Affiliations block.
The template has been copied to FRANCK:
PDQBoardMemberInfo.xml

Comment entered 2011-02-22 15:29:17 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-02-22 15:29:17
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::7

(In reply to comment #6)
> Based on the information in OCECDR-3295 I have moved the GovernmentEmployee
> element to appear after the Affiliations block.
> The template has been copied to FRANCK:
> PDQBoardMemberInfo.xml

Verified on Franck. Looks good and can be promoted to Bach when OCECDR-3295 is promoted.

Comment entered 2011-02-22 20:40:17 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-22 20:40:17
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

The following files have been versioned in SVN and copied to FRANCK and BACH:
PDQBoardMemberInfo.css - R10036
PDQBoardMemberInfo_structure.css - R10036
PDQBoardMemberInfo.xml - R10037

Please verify on BACH and close this bug.

Comment entered 2011-03-16 18:12:58 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-03-16 18:12:58
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::9

(In reply to comment #8)
> The following files have been versioned in SVN and copied to FRANCK and BACH:
> PDQBoardMemberInfo.css - R10036
> PDQBoardMemberInfo_structure.css - R10036
> PDQBoardMemberInfo.xml - R10037
>
> Please verify on BACH and close this bug.

It looks like there have been changes to the schema since this was promoted to Bach. Creating a new document returns the DTD XML Schema error on BACH. I am not sure if this is creating the error. Could you please take a look?

Comment entered 2011-03-16 18:22:48 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-03-16 18:22:48
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10

Bob sometimes forgets to update the DTD for XMetaL.

It's working now.

Comment entered 2011-03-16 18:27:13 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-03-16 18:27:13
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::11

(In reply to comment #10)
> Bob sometimes forgets to update the DTD for XMetaL.
>
> It's working now.

Yes. It works now. Thanks! Can I close this issue?

Comment entered 2011-03-16 18:29:27 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-03-16 18:29:27
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12

Yes, unless you need me to make any more changes.

Comment entered 2011-03-17 11:54:22 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-03-17 11:54:22
BZCOMMENTOR::Robin Juthe
BZCOMMENT::13

Verified on Bach; closing issue.

Elapsed: 0:00:00.001732