CDR Tickets

BZDATETIME::2011-01-13 16:32:47
BZCOMMENTOR::Bob Kline
BZCOMMENT::1

The new element has been installed on Mahler; ready for user testing.

BZDATETIME::2011-01-13 16:33:49
BZCOMMENTOR::Bob Kline
BZCOMMENT::2

Attachment report4985.xls has been added with description: Requested spreadsheet

BZDATETIME::2011-01-13 17:19:48
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::3

(In reply to comment #1)
> The new element has been installed on Mahler; ready for user testing.

Verified on Mahler. Please promote to Bach.

--I got a lot of errors that were unrelated to this schema change. For example, if I add the affiliation information, I was getting schema validation errors. However, on Bach everything looks fine with the affiliation information so it might just be something minor. It may also be because the BM documents are not published, users are not doing a validation check before saving them.

BZDATETIME::2011-01-13 17:31:12
BZCOMMENTOR::Robin Juthe
BZCOMMENT::4

I don't know that there's any real value in going back to old Board member records and adding the govt employee status, especially since a default value of unknown will be added anyway. Could the spreadsheet be revised to exclude those with a current member=No status (or, include those with current member=Yes) in their Board Member document?

BZDATETIME::2011-01-13 17:38:55
BZCOMMENTOR::Bob Kline
BZCOMMENT::5

(In reply to comment #4)
> Could the spreadsheet be revised to exclude
> those with a current member=No status (or, include those with current
> member=Yes) in their Board Member document?

I thought I did that already. Can you give me some examples of those you think shouldn't be on the list?

BZDATETIME::2011-01-14 09:00:24
BZCOMMENTOR::Bob Kline
BZCOMMENT::6

Examples, please. Were the documents valid before you started editing them?

BZDATETIME::2011-01-14 09:20:51
BZCOMMENTOR::Robin Juthe
BZCOMMENT::7

Sure. I thought about this some more and I think the issue is that some Board members have multiple Board membership blocks with differing current member statuses. Here are a couple of examples:

Marianne Berwick is a current member of the Genetics ADVISORY Board and a former member of the Genetics EDITORIAL Board. She shows up in both lists.

Kathy Helzlhouer is a current member of the Screening & Prevention Editorial Board and a former member of the Genetics Editorial Board. She shows up in both lists.

I could fix this by sorting by person name, deleting duplicates, and then re-sorting by Board. However, I won't know if I'm deleting the right instance of each Board member (ie the correct Board association) without looking at the records.

So, would it be possible to either weed out the occurrences where the board membership for a particular board is 'no' OR to add a column of membership status (current member element) with a 'Y' or 'N' indicator?

BZDATETIME::2011-01-14 10:00:39
BZCOMMENTOR::Bob Kline
BZCOMMENT::8

How's this?

Attachment report4985.xls has been added with description: Replacement report

BZDATETIME::2011-01-14 10:48:05
BZCOMMENTOR::Robin Juthe
BZCOMMENT::9

Looks good. I'll share this with the other Board managers so that they can fill in their Board members' Ys and Ns. Thanks.

BZDATETIME::2011-01-14 13:25:28
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::10

(In reply to comment #6)
> Examples, please. Were the documents valid before you started editing them?

I looked at the documents again and it turned out to be a problem with where I was inserting the GovernmentEmployee element. Because the documents were invalidated when I checked them out, the rules checking notification was off and all the possible elements are displayed in the elements list. So regardless of where I placed the cursor, the GovernmentEmployee element was available as an option. After checking the schema, I was able to get them to validate.

BZDATETIME::2011-02-03 12:13:17
BZCOMMENTOR::Robin Juthe
BZCOMMENT::11

Here is the completed spreadsheet with the govt employee status of each current Editorial and Advisory Board member. This will be used to populate the element with the appropriate Y/N values.

Two members on the list have left/are in the process of leaving a Board.

One member is retired from the govt and does not receive honoraria; as discussed in the last status meeting, we would like to add an attribute to indicate his retired status. Since this will be rarely used, it should either be optional or be given a default value of retired=NO for everyone.

Attachment BoardMemberGovtEmployeeStatus.xls has been added with description: Completed Spreadsheet with Govt Employee Statuses

BZDATETIME::2011-02-03 14:57:32
BZCOMMENTOR::Robin Juthe
BZCOMMENT::12

As decided in today's status meeting, we will add an attribute on the Govt Employee element called "Receives Honoraria" (is this too long of a name?). The default value for a government employee will be 'No' and the default value for a non-govt employee will be 'Yes'. We will be able to change this manually, to solve the case of the retired govt employee who is eligible for an honorarium but has declined it.

BZDATETIME::2011-02-07 11:12:19
BZCOMMENTOR::Bob Kline
BZCOMMENT::13

Can't install the new attribute: William has the schema document locked (you probably shouldn't be editing the schema documents in XMetaL).

BZDATETIME::2011-02-18 11:52:17
BZCOMMENTOR::Bob Kline
BZCOMMENT::14

I installed the new schema on Franck, since Mahler's not ready yet.

BZDATETIME::2011-02-22 14:22:04
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::15

(In reply to comment #14)
> I installed the new schema on Franck, since Mahler's not ready yet.

Verified on Franck. I will put in a comment to promote the CSS changes to Franck also.

BZDATETIME::2011-02-22 14:53:27
BZCOMMENTOR::Volker Englisch
BZCOMMENT::16

I may be wrong but to me it looks as the GovernmentEmployee is in the wrong position (Abrams, Donald - CDR659924). The schema has it listed before the Affiliations block but in the data it seems to be entered after the Affiliations.

I thought the new GovernmentEmployee element is mandatory?

BZDATETIME::2011-02-22 14:55:48
BZCOMMENTOR::Volker Englisch
BZCOMMENT::17

(In reply to comment #16)
> I thought the new GovernmentEmployee element is mandatory?

This question doesn't really have anything to do with the first comment. I'm seeing many records without that new element for retired persons.

BZDATETIME::2011-02-22 15:08:15
BZCOMMENTOR::Bob Kline
BZCOMMENT::18

(In reply to comment #16)

> I may be wrong but to me it looks as the GovernmentEmployee is in the wrong
> position (Abrams, Donald - CDR659924). The schema has it listed before the
> Affiliations block but in the data it seems to be entered after the
> Affiliations.

I have moved the new element to follow the Affiliations block (on Franck).

BZDATETIME::2011-02-22 15:45:00
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::19

(In reply to comment #18)
> (In reply to comment #16)
>
> > I may be wrong but to me it looks as the GovernmentEmployee is in the wrong
> > position (Abrams, Donald - CDR659924). The schema has it listed before the
> > Affiliations block but in the data it seems to be entered after the
> > Affiliations.
>
> I have moved the new element to follow the Affiliations block (on Franck).

Verified on Franck.It looks good to me.

BZDATETIME::2011-02-24 14:04:31
BZCOMMENTOR::Bob Kline
BZCOMMENT::20

[From status meeting:] Next step is to populate the documents from Robin's spreadsheet on Franck.

BZDATETIME::2011-02-28 14:18:01
BZCOMMENTOR::Bob Kline
BZCOMMENT::21

I have run a test-mode job on Franck.

http://franck.nci.nih.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2011-02-28_14-06-36

There were four unique values in column D (not counting the row for the column headers):

Y (<GovernmentEmployee ReceivesHonoraria="No">Yes</GovernmentEmployee>)
N (<GovernmentEmployee ReceivesHonoraria="Yes">No</GovernmentEmployee>)
Y - Retired (<GovernmentEmployee ReceivesHonoraria="No">No</GovernmentEmployee>)
He is being removed from the Board (<GovernmentEmployee>Unknown</GovernmentEmployee>)

I noticed at least one document which failed validation, which turned out to be because someone had already added the new element to the document. I modified the script to avoid modifying any document version which already has a GovernmentEmployee element.

Ready for user review.

BZDATETIME::2011-03-01 13:27:21
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::22

(In reply to comment #21)

> Ready for user review.
Reviewed test results. They look good. Please run in live mode on Franck.

BZDATETIME::2011-03-03 14:32:29
BZCOMMENTOR::Bob Kline
BZCOMMENT::23

Change attribute to 'HonorariaDeclined' (type "Yes"); fix logic to match. Report on who get honoraria will pick up editorial board members who are not govt. employees and for whom the new attribute is not present.

BZDATETIME::2011-03-07 13:55:19
BZCOMMENTOR::Bob Kline
BZCOMMENT::24

Here's the latest schema:

http://franck.nci.nih.gov/cgi-bin/cdr/GetSchema.py?id=367308

And here is another test-mode run with the software modified to match what we decided on Thursday:

http://franck.nci.nih.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2011-03-07_13-49-22

BZDATETIME::2011-03-10 09:23:02
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::25

(In reply to comment #24)
> Here's the latest schema:
>
> http://franck.nci.nih.gov/cgi-bin/cdr/GetSchema.py?id=367308
>
> And here is another test-mode run with the software modified to match what we
> decided on Thursday:
>
> http://franck.nci.nih.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2011-03-07_13-49-22

Verified. Please run in live mode on Franck.

BZDATETIME::2011-03-15 10:03:48
BZCOMMENTOR::Bob Kline
BZCOMMENT::26

(In reply to comment #25)

> Verified. Please run in live mode on Franck.

Done.

BZDATETIME::2011-03-15 13:47:30
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::27

(In reply to comment #26)
> (In reply to comment #25)
>
> > Verified. Please run in live mode on Franck.
>
> Done.

I looked at a lot of the records on Franck and they were all OK. Please run in test mode on Bach.

BZDATETIME::2011-03-15 17:30:12
BZCOMMENTOR::Bob Kline
BZCOMMENT::28

(In reply to comment #27)

> Please run in test mode on Bach.

Done.

http://bach.nci.nih.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2011-03-15_16-25-11

BZDATETIME::2011-03-17 11:48:33
BZCOMMENTOR::Robin Juthe
BZCOMMENT::29

(In reply to comment #28)
> (In reply to comment #27)
>
> > Please run in test mode on Bach.
>
> Done.
>
> http://bach.nci.nih.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2011-03-15_16-25-11

Verified test run. Please do live run on Bach.

BZDATETIME::2011-03-22 11:39:05
BZCOMMENTOR::Bob Kline
BZCOMMENT::30

Run in live mode on Bach.

BZDATETIME::2011-03-22 11:42:28
BZCOMMENTOR::Bob Kline
BZCOMMENT::31

(In reply to comment #30)
> Run in live mode on Bach.

That was a little too ambiguous (looks too much like an instruction instead of a report of what I did). :-)

I performed a live run on Bach, which completed successfully.

BZDATETIME::2011-03-23 16:45:22
BZCOMMENTOR::Robin Juthe
BZCOMMENT::32

(In reply to comment #31)
> I performed a live run on Bach, which completed successfully.

Verified on Bach. Closing issue.

I will open a separate issue to develop a report (as mentioned in comment 23).