CDR Tickets

Issue Number 3280
Summary [Summary] Key Point display problems in QC reports
Created 2010-12-09 10:16:13
Issue Type Bug
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-02-17 11:47:03
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107608
Description

BZISSUE::4970
BZDATETIME::2010-12-09 10:16:13
BZCREATOR::William Osei-Poku
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

First level Key Points are running together with initial 2nd level Key Points in QC reports. Example, in the Pancreatic summary (CDR 62957), the Patient B/U QC report displays the key Points below in one line:

"The following stages are used for pancreatic cancer:
Stage 0 (Carcinoma in Situ)”

The display problem is also found in the Redline Strikeout QC report.
Also, none of the 2nd level Key Points are showing as bullets in the boxes in QC reports. In this example, stages and treatments shown as second level Key Points should be appearing in the corresponding boxes as sub-bullets, but are not.

However, publish preview displays the key Points correctly.

Comment entered 2010-12-09 10:34:06 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-12-09 10:34:06
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

Isn't this the same problem that was reported, fixed and verified in OCECDR-3231 a couple of months ago?

Is this problem a result of that fix or would you know when this problem first occurred?

Comment entered 2010-12-09 11:25:54 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-12-09 11:25:54
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::2

(In reply to comment #1)
> Isn't this the same problem that was reported, fixed and verified in OCECDR-3231 a
> couple of months ago?
> Is this problem a result of that fix or would you know when this problem first
> occurred?

The one you recently fixed was kind of general - key points running together. This one appears to affect only Key Points with First and Second levels. Also, the one you recently fixed did not affect the bullets in the boxes but this one does. This issue was reported to me only yesterday but according to users, they first came across it about 2 weeks ago when I was out of the office.

Comment entered 2010-12-09 11:44:39 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-12-09 11:44:39
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

> according to users, they first came across it about 2 weeks ago when
> I was out of the office.

That's odd because there hasn't been a filter change on BACH since Oct. 15th.
It probably would have been easier to track this problem if we had been notified about the change in behavior immediately. Oh well, too late now.

Comment entered 2010-12-10 17:08:24 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-12-10 17:08:24
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

I looked at my code changes from OCECDR-3231 and these problems were indeed introduced with those changes that were supposed to resolve the problem of KeyPoint elements being concatenated. I had fixed the KeyPoint display for the first level KeyPoints which in turn messed up the display of the second level KeyPoints.

This has now been fixed on MAHLER.
Please make sure to test different documents with different KeyPoint scenarios to make sure this fix didn't introduce yet another bug.

While I was working on this problem I've noticed that many display items were still displayed without the use of CSS (CSS = make things pretty), so I've made some additional changes to the report which I hope will help CIAT making this report more useful. The additional changes implemented are:
a) The Key Points box is now displayed in color.
b) The Key Points box is now displayed with a semi-fixed width (80% of
the display window)
c) The TOC is now displayed in bold and blue (navy)
d) The TOC items are now links to the summary sections.

Again, when testing please have a look at a variety of summaries and report types to ensure I didn't accidentally break something.

The following filters have been modified:
CDR409593.xml - Copy XML for Summary Report
CDR434822.xml - Module: QC Filter Templates - Summary
CDR339576.xml - Module: InLine Markup Formatter
CDR380958.xml - Module: STYLE QC Summary

This is ready for review on MAHLER.

Comment entered 2010-12-14 12:29:37 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-12-14 12:29:37
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::5

> This is ready for review on MAHLER.

Users are excited about all the enhancements you did. Thank you!

The changes have been tested on Mahler. Please promote to Bach.

Comment entered 2010-12-14 13:48:45 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-12-14 13:48:45
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

(In reply to comment #5)
> Users are excited about all the enhancements you did. Thank you!

I am glad to hear that. Sometimes I worry that a change that I make as an "enhancement" might not be seen by everybody as an improvement. Been there. :-)

Unfortunately, we will have to wait for the changes in OCECDR-3245 to be approved before I can copy these KeyPoint changes to BACH since the two issues are sharing the same filters.

Comment entered 2011-02-16 16:23:28 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-16 16:23:28
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

The following filter have been copied to FRANCK and BACH:
CDR335166.xml - Module: Checkbox Formatter - R10032 (OCECDR-3277)
CDR339576.xml - Module: InLine Markup Formatter - R10032 (issues OCECDR-3280, OCECDR-3245)
CDR380956.xml - Module: STYLE BU Insertion Deletion - R10032 (OCECDR-3277,4934)
CDR380957.xml - Module: STYLE RS Insertion Deletion - R10032 (OCECDR-3277,4934)
CDR380958.xml - Module: STYLE QC Summary - R10032 (OCECDR-3277,4970,
4934)
CDR409593.xml - Copy XML for Summary Report - R10032 (OCECDR-3280)
CDR434822.xml - Module: QC Filter Templates - Summary - R10032 (OCECDR-3280)

The following program has been copied to FRANCK and BACH:
QcReports.py - R10033

Please verify on BACH and close this bug.

Comment entered 2011-02-17 11:47:03 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-02-17 11:47:03
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::8

(In reply to comment #7)
>
> The following program has been copied to FRANCK and BACH:
> QcReports.py - R10033
>
> Please verify on BACH and close this bug.

Verified. Closing this issue. Thank you!

Elapsed: 0:00:00.001824