CDR Tickets

Issue Number 3258
Summary [DIS] New Attribute on DrugReference Block
Created 2010-10-28 15:27:46
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2010-11-22 13:32:07
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107586
Description

BZISSUE::4948
BZDATETIME::2010-10-28 15:27:46
BZCREATOR::Robin Juthe
BZASSIGNEE::Bob Kline
BZQACONTACT::William Osei-Poku

We would like to add a new attribute on the DrugReference block in Drug Information Summary documents in order to choose which list the item (e.g., clinical trial results, MedlinePlus information) will appear on Cancer.gov.

The 2 lists on Cancer.gov will be "About ___" where the ___ is the drug name and "Research Results".

The attribute should be required and it will be named "Section". The values will be "About-Drug" and "Research-Results".

We will later want to add the attribute "About-Drug" to the template for new documents since we envision that this option will be used more often.

Comment entered 2010-10-29 18:11:56 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-10-29 18:11:56
BZCOMMENTOR::Bob Kline
BZCOMMENT::1

Attribute installed on Mahler; ready for user testing.

Comment entered 2010-11-01 12:58:44 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2010-11-01 12:58:44
BZCOMMENTOR::Robin Juthe
BZCOMMENT::2

This looks good on Mahler. Please promote.

Comment entered 2010-11-02 15:42:52 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-11-02 15:42:52
BZCOMMENTOR::Bob Kline
BZCOMMENT::3

Promoted to Bach and Franck; please check (and close if OK).

Comment entered 2010-11-05 15:28:55 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-11-05 15:28:55
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

I noticed that the FDA DrugReference section on MAHLER had an empty attribute which will prevent the document from validating. Either we will have to make the section attribute optional or we will need to add a third value for the section attribute to the schema.
Making the attribute optional would require the filters to detect the FDA DrugReference to be identified base on the DrugReferenceType value which we said we would not want to use for the new filters.
After talking to Margaret we're thinking that the best option would be to leave the attribute mandatory and add a third value 'fda' to the drop-down list.

Comment entered 2010-11-05 15:40:10 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-11-05 15:40:10
BZCOMMENTOR::Bob Kline
BZCOMMENT::5

New value installed on Mahler; ready for user testing.

Comment entered 2010-11-05 15:53:40 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-11-05 15:53:40
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

Just as the doctor ordered. The documents can now be validated.

I'll let Robin decide when this should get moved to BACH.

Comment entered 2010-11-08 14:54:35 by Beckwith, Margaret (NIH/NCI) [E]

BZDATETIME::2010-11-08 14:54:35
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::7

I am checking this since Robin is out of town. It seems to me that the values need to have upper case letters to be consistent with our style don't they? So it would be About-Drug, Research-Results, FDA. After that, it can be promoted to Bach.

Comment entered 2010-11-08 15:01:32 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-11-08 15:01:32
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

(In reply to comment #7)
> So it would be About-Drug, Research-Results, FDA.

Shouldn't it rather be
About-drug, Research-results, and Fda
instead? I thought we're only capitalizing the first character.

Comment entered 2010-11-08 15:17:45 by Beckwith, Margaret (NIH/NCI) [E]

BZDATETIME::2010-11-08 15:17:45
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::9

I wasn't sure since the second word came after a dash. For sure I want to capitalize all letters in FDA since it is an abbreviation. We seem to be inconsistent in the way we do this (what a surprise!). In the Org schema where we added the values for reasons for canceling a Board meeting, we use an underscore instead of a dash, and don't capitalize the second word. Other places we capitalize after a dash. We could go with About_drug, Research_results, FDA.

Comment entered 2010-11-08 15:28:52 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-11-08 15:28:52
BZCOMMENTOR::Bob Kline
BZCOMMENT::10

I don't think it really makes any difference what the style is for these values, since they'll never be published: they're just triggers for decisions made by Volker's filters. But if you're really hoping for some capital letters here I'll be happy to change the values to whatever is finally decided.

Comment entered 2010-11-18 11:46:54 by Beckwith, Margaret (NIH/NCI) [E]

BZDATETIME::2010-11-18 11:46:54
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::11

About_drug,
Research_results, FDA

Comment entered 2010-11-18 16:12:56 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-11-18 16:12:56
BZCOMMENTOR::Bob Kline
BZCOMMENT::12

New style installed on Mahler; ready for user testing.

Comment entered 2010-11-19 09:08:11 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2010-11-19 09:08:11
BZCOMMENTOR::Robin Juthe
BZCOMMENT::13

Verified on Mahler. Please promote these changes to Bach.

Comment entered 2010-11-22 10:43:22 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-11-22 10:43:22
BZCOMMENTOR::Bob Kline
BZCOMMENT::14

New attribute installed on Bach; please check (and close if OK).

Comment entered 2010-11-22 13:32:07 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2010-11-22 13:32:07
BZCOMMENTOR::Robin Juthe
BZCOMMENT::15

Verified on BACH. Closing issue.

Elapsed: 0:00:00.001389