CDR Tickets

Issue Number 3105
Summary Have certain links to unpublished docs ignored
Created 2010-03-05 09:46:43
Issue Type Improvement
Submitted By Beckwith, Margaret (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2010-04-08 15:31:26
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107433
Description

BZISSUE::4781
BZDATETIME::2010-03-05 09:46:43
BZCREATOR::Margaret Beckwith
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

I have had two requests to have certain links to unpublished documents ignored during publishing. They are:

1. Have the glossary link in the Drug Information summaries ignored if it points to an unpublished glossary term. We already do this for glossary refs in the summaries documents.
2. Have the Proposed Use link to a glossary term OR to a summary in the Media docs ignored.

In both cases the users are putting in links to documents that are still being worked on, and they have to remember to go back and add the links in later since it makes the documents they are working on invalid.

Comment entered 2010-03-30 17:22:41 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-03-30 17:22:41
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

(In reply to comment #0)
> I have had two requests to have certain links to unpublished documents ignored
> during publishing.

I just want to clarify that we probably don't want these links ignored during publishing because the GlossaryLink for the DIS is a mandatory element.
I believe what we want to do is ensure that PublishPreview won't fail with an error because of the missing publishable document that the link points to.

Do we want to make these changes for PublishPreview only or also for the QC reports?

Comment entered 2010-03-30 17:40:51 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-03-30 17:40:51
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

I have another question regarding this Publish Preview report.
From experience I know that the users are sometimes running the PP report without a GlossaryTerm specified at all. Since the DTD requires the GlossaryTerm element we would need to artificially create one to go through Cancer.gov's document validation.
Should we allow the PP report to run if there doesn't exist a publishable version and only a version of the document or do we not require an existing document at all?

Comment entered 2010-03-31 16:46:06 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-03-31 16:46:06
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

The following filters have been modified:
CDR433160 - R9567: Denormalization Filter (1/1): Media
CDR482943 - R9567: Module: Summary Denormalization
CDR486313 - R9567: Denormalization Filter: DrugInfoSummary

The following programs have been modified:
Filter.py - R9568
PublishPreview.py - R9568
QcReport.py - R9568

The users should now be able to run the QC and PP reports when
a) no publishable version of the linked-to document exists and
b) the cdr:ref attribute hasn't specified at all.

This is ready for review on MAHLER.

Comment entered 2010-04-07 10:23:08 by Beckwith, Margaret (NIH/NCI) [E]

BZDATETIME::2010-04-07 10:23:08
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::4

I think I tested this correctly and everything looked good. I added a glossary link to an unpublished glossary term name in a DIS and was able to save, validate, create a version, and run Pub.Preview without any problems. I added an empty Proposed Use element to a media doc and was also able to save, validate, create a version and run the QC report without any problem. If this is adequate testing, then we can promote this.

Comment entered 2010-04-07 10:35:58 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-04-07 10:35:58
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

One of the main issues, I believe, was the case where Deb added the name for a GlossaryTerm to a Drug Summary but did not link to it (because it didn't exist yet). Therefore the cdr:ref attribute of that link was empty and the PP report failed because that link couldn't be denormalized.

Comment entered 2010-04-07 12:22:00 by Beckwith, Margaret (NIH/NCI) [E]

BZDATETIME::2010-04-07 12:22:00
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::6

I took the glossary term link out of a DIS and was able to save and run PUblish Preview, so i guess we are good to go. Please promote.

Comment entered 2010-04-07 17:43:45 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-04-07 17:43:45
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

I ran a small publishing job on FRANCK to ensure that the changes to the denormalization filter for Media and Drug Summaries would have no affect on the publishing output. The diff did not show any change.

The following filters and programs have been copied to FRANCK and BACH:
CDR433160 - R9567: Denormalization Filter (1/1): Media
CDR482943 - R9567: Module: Summary Denormalization
CDR486313 - R9567: Denormalization Filter: DrugInfoSummary

Filter.py - R9568
PublishPreview.py - R9568
QcReport.py - R9568

Please verify on BACH and close this bug.

Comment entered 2010-04-08 15:31:26 by Beckwith, Margaret (NIH/NCI) [E]

BZDATETIME::2010-04-08 15:31:26
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::8

Dottie and Diana confirmed that this works in media docs and DIS, respectively. Issue closed.

Elapsed: 0:00:00.001548