CDR Tickets

BZDATETIME::2010-04-05 16:45:47
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::1

I have attached the specifications including the draft email.

Attachment publication Notification Email.docx has been added with description: Publication Notification email

BZDATETIME::2010-05-14 16:14:44
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::2

Lakshmi and I have reviewed the text to be sent when a person's record is published to Cancer.gov.

Attachment publication Notification EmailFinal.docx has been added with description: Publication notification email reviewed

BZDATETIME::2010-05-14 16:29:41
BZCOMMENTOR::Lakshmi Grama
BZCOMMENT::3

I think I missed one thing in my review of the text - the subject line should read

"NCI Cancer Genetics Services Directory Listing Notification"

BZDATETIME::2010-06-08 16:44:18
BZCOMMENTOR::Bob Kline
BZCOMMENT::4

I have implemented this on Mahler. I had to fudge the logic a little bit in order to test, because the software wasn't finding any published GP docs which weren't also legacy documents. So it avoids sending the same notification twice (meaning for testing you'll want to throttle the number sent out at once), but doesn't (yet) avoid sending notifications to legacy GPs.

After you let me know who I should plug into the list of test recipients who get the messages instead of the real GP, I'll put this in the admin menus.

BZDATETIME::2010-06-08 17:09:35
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::5

(In reply to comment #4)

> After you let me know who I should plug into the list of test recipients who
> get the messages instead of the real GP, I'll put this in the admin menus.

1.jmorris@icfi.com
2.lhoward3@icfi.com
3.wosei-poku@icfi.com

BZDATETIME::2010-06-08 17:15:54
BZCOMMENTOR::Bob Kline
BZCOMMENT::6

Installed on Mahler; ready for user testing.

BZDATETIME::2010-06-09 11:47:22
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::7

(In reply to comment #6)
> Installed on Mahler; ready for user testing.

The text of the email does not appear to match the approved version posted by Margaret in comment #2. The two discrepancies I can see are:

1. The link to search the directory should be on the word 'Directory' but it is currently on the word 'searching'.

2. The email is signed off as 'The NCI Genetics Services Directory Team' but the approved version has 'The NCI Cancer Genetics Services Directory Coordinator'.

BZDATETIME::2010-06-09 12:25:50
BZCOMMENTOR::Bob Kline
BZCOMMENT::8

Actually, lots of other text didn't match the final version. I had seen the comment "Lakshmi and I have reviewed the text ..." but I missed the fact that they had made some changes (and attached them). I believe I have updated all the places they changed.

BZDATETIME::2010-06-09 13:32:52
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::9

Verified on Mahler. Please promote to Bach.

BZDATETIME::2010-06-09 16:13:38
BZCOMMENTOR::Bob Kline
BZCOMMENT::10

(In reply to comment #9)
> Verified on Mahler. Please promote to Bach.

Before we do, are there any published GPs on Franck that aren't legacy mailers so we can test the code which suppresses sending the notification to legacy GPs but sends them to new published GPs?

BZDATETIME::2010-06-09 16:37:16
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::11

(In reply to comment #10)
> (In reply to comment #9)
> > Verified on Mahler. Please promote to Bach.
>
> Before we do, are there any published GPs on Franck that aren't legacy mailers
> so we can test the code which suppresses sending the notification to legacy GPs
> but sends them to new published GPs?

If the software is looking for the presence of the Legacy Data block to determine the legacy GPs then, the situation on Franck will be like Mahler because we had to add the Legacy blocks to new non legacy GPs because the Vendor filter at some point required it. What about, if I removed the Legacy Data from some of the new ones created after conversion? Will this work?

BZDATETIME::2010-06-09 16:51:44
BZCOMMENTOR::Bob Kline
BZCOMMENT::12

You mean you made up bogus legacy information in the production documents? Does Lakshmi know about this? If cancer.gov needed fake data in the published documents, why didn't we put it in further downstream instead of storing false information in the repository?

BZDATETIME::2010-06-09 17:05:44
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::13

(In reply to comment #12)
> You mean you made up bogus legacy information in the production documents?
> Does Lakshmi know about this? If cancer.gov needed fake data in the published
> documents, why didn't we put it in further downstream instead of storing false
> information in the repository?

No. As I can remember, at some point, the filters required that we add legacy ID and we put the CDR ID of the document in the Legacy ID element until the issue with vendor filters was resolved (These were discussed under the vendor filter issue for GPs and in the CDR meetings). We are talking about 20 new documents for which we have to go back and remove the Legacy information from.

BZDATETIME::2010-06-09 17:21:16
BZCOMMENTOR::Bob Kline
BZCOMMENT::14

Please take all of the bogus data out of the documents on all three servers and test the new script on Mahler and Franck. If the software behaves correctly I'll promote it to Bach. Notification messages created on Mahler and Franck will be sent to the test addresses instead of the real GP email addresses.

BZDATETIME::2010-06-10 10:12:34
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::15

(In reply to comment #14)
> Please take all of the bogus data out of the documents on all three servers and
> test the new script on Mahler and Franck. If the software behaves correctly
> I'll promote it to Bach. Notification messages created on Mahler and Franck
> will be sent to the test addresses instead of the real GP email addresses.

sure - I will post a comment when this is done.

BZDATETIME::2010-06-14 12:07:54
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::16

(In reply to comment #15)
> (In reply to comment #14)
> > Please take all of the bogus data out of the documents on all three servers and
> > test the new script on Mahler and Franck. If the software behaves correctly
> > I'll promote it to Bach. Notification messages created on Mahler and Franck
> > will be sent to the test addresses instead of the real GP email addresses.
>
> sure - I will post a comment when this is done.

Done.

The last sentence in the email has the name of the directory as "NCI Cancer Genetics Directory". I think it will be good change it to match the name in the subject and beginning of the email text which is - "NCI Cancer Genetics Services Directory", (The word 'Services' is omitted from the last sentence).

BZDATETIME::2010-06-14 13:34:53
BZCOMMENTOR::Bob Kline
BZCOMMENT::17

Text modification installed on Mahler and Franck; ready for user testing.

BZDATETIME::2010-06-14 13:58:36
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::18

Another text change:
The email is signed off as "The NCI Genetics Services Directory Coordinator" ('Cancer' is omitted). It should read "The NCI Cancer Genetics Services Directory Coordinator” so that it will be consistent with other references in the email. Otherwise, everything else looks good and the program is working as expected.

BZDATETIME::2010-06-14 14:39:30
BZCOMMENTOR::Bob Kline
BZCOMMENT::19

Text modification installed on Mahler and Franck; ready for user testing.

BZDATETIME::2010-06-14 14:52:19
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::20

(In reply to comment #19)
> Text modification installed on Mahler and Franck; ready for user testing.

Verified on Franck. Please promote to Bach.

BZDATETIME::2010-06-14 14:59:53
BZCOMMENTOR::Bob Kline
BZCOMMENT::21

Promoted to Bach; please check (and close if OK). I assume you tested all paths (including entering a specific CDR ID for a particular GP), right?

BZDATETIME::2010-06-15 11:47:43
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::22

(In reply to comment #21)
> Promoted to Bach; please check (and close if OK). I assume you tested all
> paths (including entering a specific CDR ID for a particular GP), right?

Thanks for reminding me. I thought I had tested it but I went back and tested and the specific CDR ID function is not working. It still picks up all the candidates for the notification.

BZDATETIME::2010-06-15 13:33:50
BZCOMMENTOR::Bob Kline
BZCOMMENT::23

Bug fixed; try the test again.

BZDATETIME::2010-06-15 14:23:54
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::24

(In reply to comment #23)
> Bug fixed; try the test again.

Verified. It works perfectly. Thanks!

BZDATETIME::2010-06-17 11:24:31
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::25

Closing issue. The notifications have been sent from Bach and we got some responses.