CDR Tickets

BZDATETIME::2008-10-10 13:12:42
BZCOMMENTOR::Bob Kline
BZCOMMENT::1

(In reply to comment #0)
> We would like to link between drug information summaries using a DrugSummaryRef
> instead of an external ref which is what is being used now. We need to add
> this element to the DIS schema. It is only in the glossary concept document
> now for linking to drug summaries.
>

Which phrase in the request takes precedence here: "we need to add this element ..." (that is, we want both elements) or "instead of ..." (in other words replace the existing element with DrugSummaryRef)?

BZDATETIME::2008-10-14 09:55:13
BZCOMMENTOR::Bob Kline
BZCOMMENT::2

New element added to schema on Mahler; ready for user testing.

BZDATETIME::2008-10-14 10:44:37
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::3

The Linking Table called Drug Summary appears to have been created on Franck and Bach, but not on Mahler. Could it please be created on Mahler so I can test adding the ability to link from one DIS to another using the new element DrugSummaryRef?

BZDATETIME::2008-10-14 10:49:50
BZCOMMENTOR::Bob Kline
BZCOMMENT::4

New link type has been created on Mahler.

BZDATETIME::2008-10-14 11:05:09
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::5

This looks good, and is ready to promote. I need to put in an issue to have it display correctly in the CSS and QC report. I will close this issue after everything has been promoted.

BZDATETIME::2008-10-14 11:09:45
BZCOMMENTOR::Bob Kline
BZCOMMENT::6

Promoted to Bach and Franck.

BZDATETIME::2008-10-20 14:30:03
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::7

When I qc'd this I didn't pay attention to the placement of this element. It needs to be an optional element that will be used inline in the Summary Section part of the DIS.

BZDATETIME::2008-10-20 14:57:43
BZCOMMENTOR::Bob Kline
BZCOMMENT::8

The SummarySection portion of the DIS documents uses the common SummarySection definition. I'm going to guess that you are asking for the new element to be added to the OtherPhraseElements group, which is in turn used as part of the paragraph-level elements, which in turn make up part of SummarySection blocks. Is this right? Any problems with making these DrugSummaryRef elements available inside any paragraph anywhere in the repository?

BZDATETIME::2008-10-20 15:28:26
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::9

I don't see any problem with that. We may want to link from a summary to a DIS in the near future. Unless Lakshmi weighs in differently, I think it is okay to go ahead with the change.

BZDATETIME::2008-10-22 10:38:52
BZCOMMENTOR::Bob Kline
BZCOMMENT::10

New element backed out of the DIS schema and inserted into the common schema's choice group for inline markup. Installed on Mahler; ready for user testing.

BZDATETIME::2008-10-22 14:52:42
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::11

Looks good. Please promote.

BZDATETIME::2008-10-22 15:08:46
BZCOMMENTOR::Bob Kline
BZCOMMENT::12

Promoted to Bach and Franck; please check (and close if OK).

BZDATETIME::2008-10-23 08:56:36
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::13

Diana tested this on Bach and everything looks good. Closing issue.

BZDATETIME::2008-12-15 11:38:27
BZCOMMENTOR::Volker Englisch
BZCOMMENT::14

It looks like the new DrugSummaryRef element has been used for the first time during publishing last Friday.
Unfortunately, all three documents failed with a validation error:
Element DrugSummaryRef is not declared in Para list of possible children

http://bach.nci.nih.gov/cgi-bin/cdr/PubStatus.py?id=5745&type=FilterFailure&flavor=error

It is not obvious to me where the problem is so I'm reopening this issue for Bob to have a look.

BZDATETIME::2008-12-15 11:52:39
BZCOMMENTOR::Bob Kline
BZCOMMENT::15

The validation appeared in the DTD validation, right? So there's a disconnect between what the publishing filters are generating and what the DTD will accept. Assuming the filters are generating what we want, then the problem would be fixed by adjusting the DTD to match what the filter emits. So the problem is not really directly related to this schema issue. Or am I missing something?

BZDATETIME::2008-12-15 13:31:02
BZCOMMENTOR::Volker Englisch
BZCOMMENT::16

(In reply to comment #15)
> The validation appeared in the DTD validation, right?

Duh! Of course.
There is a DrugRef element defined in the licensee DTD. Either we need to change the filter to convert the DrugSummaryRef to a DrugRef or we need to add a DrugSummaryRef to the licensee DTD.

BZDATETIME::2008-12-15 16:19:03
BZCOMMENTOR::Lakshmi Grama
BZCOMMENT::17

Can you attach the DTD to this issue - I don't remember what the DrugRef was supposed to do. Also, one of the steps that we always go through, that we seemed to have missed with this addition to the schema, is determine if it will have any impact on the DTD and on Cancer.gov. I have to admit that I did not look at this issue, although by default I was the QA.

BZDATETIME::2008-12-15 16:25:30
BZCOMMENTOR::Volker Englisch
BZCOMMENT::18

Attachment pdq.dtd has been added with description: Licensee DTD

BZDATETIME::2008-12-16 15:58:59
BZCOMMENTOR::Bob Kline
BZCOMMENT::19

Passing this on to you, Volker.

BZDATETIME::2008-12-18 15:35:41
BZCOMMENTOR::Volker Englisch
BZCOMMENT::20

Per discussion at the status meeting:
There is nothing we can do at this point because the Gatekeeper software will need to be modified in order to handle this new DrugSummaryRef element.

We will add a new issue collecting all DIS changes that need to be presented to the Cancer.gov team.

The DIS team will have to use external refs until then rather than DrugSummaryRefs.

Should we keep this issue open but drop the priority or should we close it and reopen when Gatekeeper is ready to accept DrugSummaryRefs?

BZDATETIME::2008-12-29 11:03:20
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::21

I lowered the priority to 10. Not sure when this will make it onto the cancer.gov books.

BZDATETIME::2009-01-06 15:55:53
BZCOMMENTOR::Volker Englisch
BZCOMMENT::22

Margaret, I heard today that the Cancer.gov is starting to being redesigned. You might want to bring this issue up with Olga to move the issue within the range of her radar.
We talked about this today in our status meeting but Olga wanted to wait until an "official" request for this change comes to her before addressing it.

BZDATETIME::2009-01-06 17:01:57
BZCOMMENTOR::Lakshmi Grama
BZCOMMENT::23

I did bring it up at the last Web Operations Team meeting (just before the holidays) as an example of where we need to develop new processes for bringing up feature requests to the core Cancer.gov content. We did not come to a total consensus on the process but did feel that requests of this scope did not really need to be approved by the Web Ops team. I will follow up with Olga with an email detailing what we would like to do.

BZDATETIME::2012-01-03 10:32:39
BZCOMMENTOR::Volker Englisch
BZCOMMENT::24

(In reply to comment #21)
> I lowered the priority to 10. Not sure when this will make it onto the
> cancer.gov books.

Just wondering if this issue should still be open to stay on the radar or if we should close it. The issue is listed as a P10 for a while now.

I read through this issue, and actually all of the work had been done in the CDR. This is now a cancer.gov issue, becuase they need to be able to accept the DrugSummaryRef element. Volker, would you mind reading through this and letting me know if this is still something we could implement (since all of the work of adding the element was done)?

Not going to happen.