CDR Tickets

Issue Number 2627
Summary Mailer Tracking documents - change from Read-only
Created 2008-08-29 11:30:23
Issue Type Improvement
Submitted By priced
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2008-09-03 16:47:49
Resolution Won't Fix
Path /home/bkline/backups/jira/ocecdr/issue.106955
Description

BZISSUE::4262
BZDATETIME::2008-08-29 11:30:23
BZCREATOR::Sheri Khanna
BZASSIGNEE::Bob Kline
BZQACONTACT::Sheri Khanna

I would like to propose that we modify the XMetal macro for the Mailer Tracking documents to make them like other document types in the CDR, which are not read-only. The element blocks that are populated when mailers are sent out are read-only and this has caused numerous issues for the part of the template that we do edit for responses. The blocks that we are able to edit have to be added with a macro and users cannot position their mouse anywhere else in the document before adding the macro or the macro cannot be added. We are having additional issues trying to add the new Call Log block in the document. The entire document (including the blocks that are added for editing) can easily become read-only with the click of a mouse.

To sum this up, CTGov documents that are imported are not read-only, so it is necessary for the Mailer Tracking documents to be?

Please comment and let me know your thoughts. We need to get the mailer tracking document in working order with the new modifications as soon as possible.

Comment entered 2008-08-29 11:42:18 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2008-08-29 11:42:18
BZCOMMENTOR::Bob Kline
BZCOMMENT::1

That's a user decision. If OCCM wants to make the entire document editable, we can do that.

Comment entered 2008-08-29 14:21:58 by priced

BZDATETIME::2008-08-29 14:21:58
BZCOMMENTOR::Sheri Khanna
BZCOMMENT::2

(In reply to comment #1)
> That's a user decision. If OCCM wants to make the entire document editable, >we can do that.

Margaret and Lakshmi, is this okay with you? The document will be a lot easier to work with it we modify this.

Comment entered 2008-09-02 16:56:03 by Grama, Lakshmi (NIH/NCI) [E]

BZDATETIME::2008-09-02 16:56:03
BZCOMMENTOR::Lakshmi Grama
BZCOMMENT::3

Is there no way we can keep the mailer content read-only and solve the other issues? If not, then I am OK with making the document editable. CIAT will need to be extra careful not to change other data. I know Sheri compared these records to CTGOV, but I think the CTGOV data is somewhat different in that even if we do mess up the imported content, the next update to the record in CTGOV will fix our mess.

Comment entered 2008-09-03 10:35:06 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2008-09-03 10:35:06
BZCOMMENTOR::Bob Kline
BZCOMMENT::4

(In reply to comment #3)
> Is there no way we can keep the mailer content read-only and solve the other
> issues?

I'm not sure, because I don't completely follow the description of the issues (what would it mean for the user to add a macro, for example?). Perhaps after tomorrow's meeting Sheri can come by my office and show me the problems the users are reporting.

Comment entered 2008-09-03 11:00:39 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2008-09-03 11:00:39
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

The problem at the moment is less a problem of the users but a problem of the programmer (which would be me).

The mailer document has been made read-only except for a few elements that the users are allowed to add. If one tries to add an element at the wrong place at the wrong time an error is displayed notifying the user of this event. After this notification the entire document becomes read-only, including the supposedly read/write elements the users are adding/editing.

I'm sure if I find out how to debug the XMetaL macros I will be able to fix this but we were just wondering if there was a compelling reason why the mailer documents were the only document type that is write protected.

Comment entered 2008-09-03 11:12:33 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2008-09-03 11:12:33
BZCOMMENTOR::Bob Kline
BZCOMMENT::6

What happens if you add the names of the new elements you want the users to be able to edit to the cdrIsReadOnly() function? Why not just add a macro for inserting a new CallLog block, which is the same technique they use for inserting the Response block?

Comment entered 2008-09-03 11:30:31 by priced

BZDATETIME::2008-09-03 11:30:31
BZCOMMENTOR::Sheri Khanna
BZCOMMENT::7

(In reply to comment #6)
> What happens if you add the names of the new elements you want the users to be
> able to edit to the cdrIsReadOnly() function? Why not just add a macro for
> inserting a new CallLog block, which is the same technique they use for
> inserting the Response block?

We can do this but the only way the original "Response" macro works is if you open the document and immediately run the macro. If you position your cursor anywhere in the document, the macro does not work.

Comment entered 2008-09-03 11:38:04 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2008-09-03 11:38:04
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

(In reply to comment #7)
> We can do this but the only way the original "Response" macro works is if you
> open the document and immediately run the macro.

This is not exactly right. I'm able to add the Response block after adding multiple CallLog blocks.

> If you position your cursor anywhere in the document, the macro does not
> work.

I don't know if this is correct. I just noticed that you're unable to use the macros once you tried to add an element from the Element picklist or after you tried to run the Response macro a second time.

Comment entered 2008-09-03 11:40:26 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2008-09-03 11:40:26
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9

(In reply to comment #6)
> Why not just add a macro for
> inserting a new CallLog block, which is the same technique they use for
> inserting the Response block?

That's exactly what I've done and it works - until the document decides "enough is enough".

Comment entered 2008-09-03 16:47:49 by priced

BZDATETIME::2008-09-03 16:47:49
BZCOMMENTOR::Sheri Khanna
BZCOMMENT::10

Volker has made some modifications to the template, so we are going to go to promote what we have and put this request on hold for now.

Comment entered 2013-12-16 17:32:25 by Englisch, Volker (NIH/NCI) [C]

Volker has made some modifications to the template, so we are going to go to promote what we have and put this request on hold for now.

This request has been on hold for 5 years. I think it's time to put it to rest.

Closing issue.

Elapsed: 0:00:00.001513