| Issue Number | 489 |
|---|---|
| Summary | Getting console error on EBMS pages in PROD |
| Created | 2018-11-08 22:04:46 |
| Issue Type | Bug |
| Submitted By | Saxena, Supriya (NIH/NCI) [C] |
| Assigned To | |
| Status | Closed |
| Resolved | 2020-03-19 11:46:50 |
| Resolution | Cannot Reproduce |
| Path | /home/bkline/backups/jira/oceebms/issue.235866 |
Please refer to attached screenshot
Consulted with Bryan, Dion, and Joe, who confirmed that metrics.cancer.gov disappeared months ago, so this console error message (which is benign and invisible to users) has been around since then. They gave me the name of the new server, and said the fix can wait until the next EBMS release. Here's the patch:
index 11c12aa..aa0b1a6 100644
--- a/ebms.nci.nih.gov/modules/custom/ebms/js/s_code.js
+++ b/ebms.nci.nih.gov/modules/custom/ebms/js/s_code.js
@@ -274,7 +274,7 @@ s.getValOnce=new Function("v","c","e",""
changes to how your visitor data is collected. Changes should only be
made when instructed to do so by your account manager.*/
s.visitorNamespace="nci";
-s.trackingServer="metrics.cancer.gov";
+s.trackingServer="nci.122.2o7.net";
s.dc="122";
/************* DO NOT ALTER ANYTHING BELOW THIS LINE ! **************/(Ignore the warning from JIRA at the top of the patch. That's caused by a JIRA bug which will be fixed by CBIIT before the end of 2018.)
Right after I posted the patch above ~daquinohd gave me different instructions for
addressing this issue. I don't have any experience with the tools
involved so I wouldn't be able to execute the instructions. We'll reach
out to him (or someone else who knows DTM when we tackle
this ticket. Here's the high-level description from Dion:
it might be better to switch to DTM rather than fixing the old s_code; basically instead of having the s object logic and Adobe Javascript in the body, we can add a site-specific DTM tag to the HTML. Then, we can move all of that stuff into DTM where we can manage it using the DTM UI; that will also ensure that we're using a more current version of s_code.js
And here's what he provided for the steps:
Create an EBMS Web Property in DTM
Add Analytics Tool and rules to EBMS web property
Remove the legacy analytics JS from the HTML
Add the top DTM tag inside the `<head>` tag:
<script src='//assets.adobedtm.com/my_site_specifc_URL_value.js'></script>
Add the bottm DTM tag just before the `</body>` tag:
<script type="text/javascript">_satellite.pageBottom();</script>
As discussed at our status meeting ~duganal is going to identify if there is even a need to run analytics on the EBMS site. If it's not needed we can remove the s_code.js rather than fixing it.
~duganal and ~volker: I was actually hoping to put this ticket to bed as part of Biscayne. Any chance we could get an answer soon?
~bkline - Can you confirm that this error is still an issue? I checked in with Joe and he thought that error should be resolved. However, if it isn't the question of removing the code would be one for Ilene France. Technically DAP isn't required on internal tools. Ideally, at least Adobe should be kept as an Enterprise standard, but that would really be a question for Ilene France.
I don't see the message in the developer console. The ticket didn't come with repro instructions, so I can't be 100% certain that I'm trying the path which ~saxenas3 followed for this behavior, but it's very likely resolved.
I'd recommend closing the ticket, and we can open a new one if it shows up again. Thanks!
Closing ticket at Amy's suggestion.
| File Name | Posted | User |
|---|---|---|
| EBMS Error on console for all pages.JPG | 2018-11-08 22:04:36 | Saxena, Supriya (NIH/NCI) [C] |
Elapsed: 0:00:00.000685