Issue Number | 474 |
---|---|
Summary | [Search Database] Include Board Manager comments in searches run using "Comment" field |
Created | 2018-02-22 11:37:49 |
Issue Type | Improvement |
Submitted By | Juthe, Robin (NIH/NCI) [E] |
Assigned To | Kline, Bob (NIH/NCI) [C] |
Status | Closed |
Resolved | 2019-08-15 17:41:26 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/oceebms/issue.221576 |
The "Comment" field free-text search box on the search database page should search all comments on the citations, including Board manager comments.
Up until now, the search system has just looked in the
ebms_article_state_comment
table for searches with
Comment or Date Comment Added fields. It would be
complicated (and a little expensive in terms of performance) but
possible to use the existing tables to fold in the new topic-specific
comment which managers can post (though it's starting to look more like
a 13 than an 8). However, if we take the description for this ticket at
face value, looking through "all the comments" which can be
attached to articles (on the article tags, on the table to track
unavailability of full text, on the batches in which they was imported,
on jobs which printed the articles, on reviews of the articles, on
related articles, and who knows what other places I've overlooked), then
we're looking at a 60-point ticket. We'll need to:
nail down the list of comment locations to be searched
create a new table to index the comments with their dates
sweep through the database indexing all of the existing comments (with dates)
find all the places in the code where the comments are captured and add code to add the comments and dates to the new table
modify the search module to use the new comment index table
Over to you, Robin.
As we just discussed, we'd like to add one new field to the Search Database page to search Board Manager Comments.
Bob, could you also please clarify which comments are included in the current "Comments" box on the Search Database page? These are comments in the state table, I believe, but we were wondering whether it's only comments associated with a state change (added at the time of the state change), or whether subsequent comments added to a particular state were also included in the search. Thanks!
You can find an article searching on any comment associate with a state, including those comments added after the state was entered.
Great! Thanks.
Implemented on DEV.
Verified on QA.
Verified on PROD.
Elapsed: 0:00:00.000757