EBMS Tickets

Issue Number 309
Summary [General] Automatically Expand Some Pages
Created 2015-08-10 16:07:41
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2015-10-30 14:55:53
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.167205
Description

We would like to have some pages automatically expanded when you get to them to reduce the number of clicks required to get to what you want. The pages where we would like to implement this are in the literature packets and summaries tabs.

Comment entered 2015-08-25 17:27:00 by Juthe, Robin (NIH/NCI) [E]

On the MANAGE SUMMARIES page, please expand the SUMMARIES and SUPPORTING DOCUMENTS sections.

On the subpages for each summary topic, please expand each section - CANCER.GOV SUMMARIES, DOCUMENTS POSTED BY NCI, and DOCUMENTS POSTED BY BOARD MEMBERS.

These pages should be automatically expanded for all users who have access to these pages.

Comment entered 2015-10-29 09:20:59 by Kline, Bob (NIH/NCI) [C]

I didn't look closely enough at this ticket when we came up with the LOE, and I assumed we were just modifying the code to change some defaults, which would have been only moderately tricky. On closer inspection, though, I realize that the first half of this request effectively represents the creation of a new page, as we would have to incorporate the functionality of the individual summary topic pages, but in a way that supports actions for all of the summary topic pages on the same page (along the lines of what Dan implemented for the review queues in the monster citations.inc file). I think we have a number of approaches we could take to modifying the summaries pages along these lines:

  1. Change the individual summaries pages so that by default the sections are expanded when you land on the page (5 story points)

  2. The first option, plus remove the links on the main summaries page which control which section is expanded when you navigate to a summary topic page, as those links are now useless and confusing (between 5 and 8 story points)

  3. Remove the expand/collapse mechanism altogether (8 story points)

  4. Implement the ticket as originally requested (somewhere between 20 and 40 story points)

  5. Merge the functionality of the main summary page and the separate topic pages (at least 40 story points)

Comment entered 2015-10-30 09:27:13 by Shields, Victoria (NIH/NCI) [E]

Robin and I have checked with the other Board managers and the consensus is to go with #2 and #3. We like like removing any pages "in the middle" that don't need to be there, and we decided we didn't need the ability to collapse any sections now that they will all be expanded. Thanks!

Comment entered 2015-10-30 14:15:43 by Kline, Bob (NIH/NCI) [C]

Then I would suggest that we move the board member instructions for this page from the top-level landing page (which almost none of the board members will ever see) to the board-specific summary page. Make sense?

Comment entered 2015-10-30 14:55:53 by Kline, Bob (NIH/NCI) [C]

Implemented on DEV.

Comment entered 2015-10-30 14:59:24 by Shields, Victoria (NIH/NCI) [E]

Yes, it makes sense to move that text. Glad you noticed! I took a look at it and I think it's still valid without any edits.

Comment entered 2015-11-04 13:44:30 by Juthe, Robin (NIH/NCI) [E]

Bob, one thing we noticed with these pages is that now that the headings are no longer links (as they were when we were expanding/collapsing the content), they should no longer be red. Could you please make the headings black for consistency with the rest of the system? I'm speaking of the SUMMARIES and SUPPORTING DOCUMENTS headings on the Board manage summaries page, and the CANCER.GOV SUMMARIES, DOCUMENTS POSTED BY NCI, and DOCUMENTS POSTED BY BOARD MEMBERS headings on the summary subpages for each topic. Thanks.

Comment entered 2015-11-04 14:33:31 by Kline, Bob (NIH/NCI) [C]

Those heading weren't red because they were links. The requirements said they were to be black when the section was collapsed, and red when the section was expanded. Since the sections are now always expanded, they're always red.

Comment entered 2015-11-04 14:40:47 by Juthe, Robin (NIH/NCI) [E]

I see what you mean, but now that expanding/collapsing is no longer available on these pages, they're basically headings. I think we use black text for headings, right?

Comment entered 2015-11-04 14:46:56 by Kline, Bob (NIH/NCI) [C]

You can have them be any color you want. I was just explaining why I made them red (in the absence of any explicit instructions). It's a heading for an expanded section (though it's the code that's doing the expanding now instead of you). I'll change it when I get back to this code.

Comment entered 2015-11-06 09:45:02 by Kline, Bob (NIH/NCI) [C]

Made the expanded section headings black as requested.

Comment entered 2015-11-18 16:44:14 by Juthe, Robin (NIH/NCI) [E]

Verified on QA.

Comment entered 2016-04-06 14:09:09 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD.

Elapsed: 0:00:00.000643