EBMS Tickets

Issue Number 247
Summary Printing: Got an error after submitting printing job report
Created 2014-09-11 15:22:51
Issue Type Bug
Submitted By tanguturisk
Assigned To alan
Status Closed
Resolved 2014-09-13 17:27:00
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.137818
Description

Steps:
1 Go to Admin and select "print packet"
2. Select the board ("cancer genetics") from the drop down list.
3. Click submit button.
4. Go back to preview page (click browser back button) from Print job result page

Actual:
System throw an error:
Warning: Invalid argument supplied for foreach() in Ebms\EbmsPrintJob->createResponseSheet() (line 1265 of /local/content/web/appdev/sites/ebms.nci.nih.gov/modules/custom/ebms/EbmsPrint.inc).

Attached screenshot.

Comment entered 2014-09-12 00:14:42 by alan

Sridhar,

I'm not sure what you mean by step 4, "Go back to the preview page from the Print job result page". Do you mean to click the browser's Back button? Is it only after that that the error occurs?

I didn't see the error on Dev or QA, but I may not have filled in the print job request form the same way you did.

Looking at the code, it looks like what happened is that I'm trying to format an author name for display on the response sheet but retrieved an article that had no authors. There are some like that in the system. They come that way from NLM.

It's a pretty easy fix but I didn't want to fix it until I could reproduce the error - in order to be sure that my fix was right.

Let me know whether to use QA or DEV, what values to put in the print request form, and exactly when the message appears. Then I'll test, try my fix, and test again.

Thanks.

Comment entered 2014-09-12 12:09:54 by tanguturisk

Hi Alan,

I was able to reproduce on QA. You have to select board as "Cancer Genetics"
Updated the test steps.
Thanks,
ST

Comment entered 2014-09-13 17:26:21 by alan

I believe I fixed the bug, checked it in to subversion, and installed it on both Dev and QA.

While testing, I noticed a data error in the list of articles for the Cancer Genetics print list. "pubmedhelp.pdf" appeared in the list of articles with a title of "A 10-year step forward in hereditary cancer in Spain". The article for 10 year step forward (EBMS ID 330242, PMID 23225104), had a full_text_id linking to the pubmedhelp article and it appeared in 4 packets on QA.

I checked the production database and did not see these errors. So I'm assuming that these errors result either from uncorrected data on QA that was corrected in the full_text_id link bug fix on Prod, or that there were some errors made on QA for testing, or both. I'm therefore not pursuing this here but am recording it so that we have a record of it.

I'm going to mark the bug as resolved fixed.

Attachments
File Name Posted User
screenshot.gif 2014-09-11 15:22:51

Elapsed: 0:00:00.000599