| Issue Number | 214 |
|---|---|
| Summary | [Literature] Reviewed Packets page error |
| Created | 2014-07-02 16:56:26 |
| Issue Type | Bug |
| Submitted By | Shields, Victoria (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2015-11-27 11:04:51 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.131173 |
When I clicked on the Reviewed Packets page, I saw the following error:
Warning: Invalid argument supplied for foreach() in EbmsReview->get_reviewed_citation() (line 821 of /local/content/web/appdev/sites/ebms.nci.nih.gov/modules/custom/ebms/review.inc).
I reported it to Bob and he said it happened because one of the articles in the packet didn't have any authors, which the software at that spot wasn't expecting. He said it should be prepared for that condition and to report this as a bug.
I think this may be resolved by OCEEBMS-230, which is in release 3.0.
Checked the code and verified that the check for authors is present.
I can verify that this is working on DEV (using PMID: 26650174) but I cannot verify this on QA because I can't upload a PDF to the system so that the article can be included in a packet. I can't test on PROD without a "real" article (we don't come across articles with no authors very often), so I'm kind of stuck here. I'm sure this is fine but it would be good to confirm it.
I have added Erika as a watcher to the WEBTEAM ticket so she's aware of the problem. No movement on the ticket, even though I had Alan mark it as "Critical."
Thanks, Bob!
Verified on QA.
We haven't had an occasion to test this with real data yet. Closing the issues and we'll reopen if we encounter any problems.
Elapsed: 0:00:00.000769