CDR Tickets

Issue Number 5251
Summary Modify Summary Schema to include a new attribute to not push documents to Drupal
Created 2023-06-14 11:38:26
Issue Type New Feature
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2023-06-22 11:42:31
Resolution Won't Fix
Path /home/bkline/backups/jira/ocecdr/issue.348765
Description

As a CDR summary editor, I want to be able to add a new attribute to a SVPC or Partner summary so that it is not pushed to Drupal as part of the publishing process. 

Scenario: CDR is able to identify summaries that do not have to be pushed to Drupal even when they have not been blocked from publication

Given: I am a CDR summary editor

   And I have permission to create or edit summary documents

When I create or edit a SVPC or Partner summary documents

Then I want to be able to add a new attribute called "Do-Not-Push-To-Drupal" with a blank default value and an option to select a "Yes" attribute.

Comment entered 2023-06-14 13:26:45 by Kline, Bob (NIH/NCI) [C]
Comment entered 2023-06-15 12:13:50 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Please install on QA. Thanks!

Comment entered 2023-06-15 13:36:26 by Kline, Bob (NIH/NCI) [C]

Installed on QA.

Comment entered 2023-06-16 14:09:57 by Englisch, Volker (NIH/NCI) [C]

, I'm not crazy about the name for the attribute.  First of all, it is the first time we're creating attribute names with a dash "-" (if we're ignoring the internal attribute cdr-eid, so I would prefer DoNotPushToDrupal.  Secondly, I would think that PushToDrupal="No" would be a little bit clearer from a user point-of-view than DoNotPushToDrupal="Yes".

Additionally, I'm not sure we want to indicate a push/no push with the attribute at all because we already have rules for when to push and when not to push a document.  For instance, none of the documents marked as PartnerMergeSet will be pushed.  A user might think these documents will need this DoNotPushToDrupal flag set as well in order to prevent those from being pushed.  What we're really trying to say here is:  "These documents originated on Drupal.  Therefore we don't want to push these back to Drupal." Maybe an attribute called Origin="Drupal" or Source="Drupal" might better convey what we're trying to do here?

Comment entered 2023-06-20 06:58:21 by Osei-Poku, William (NIH/NCI) [C]

Hi   Either of your suggestions is fine with me (Origin/Source) as long as   is OK with it. This attribute will be set by default when the documents are first created, so users would only be educated not to change it unless told to do so.

Hi should the new attribute be applied to Partner summaries as well? If that is the case then, I will prefer DoNotPushToDrupal to Origin or Source.

Comment entered 2023-06-20 08:05:32 by Kline, Bob (NIH/NCI) [C]

Hi Kline, Bob (NIH/NCI) [C] Either of your suggestions is fine with me ...

Can you remind me what suggestions I made (and when I made them)?

Comment entered 2023-06-20 09:09:31 by Osei-Poku, William (NIH/NCI) [C]

oops, somehow, I thought you made the suggestion because this ticket is assigned to you. I didn't realize it was Volker who made the suggestions.

Comment entered 2023-06-22 11:02:44 by Osei-Poku, William (NIH/NCI) [C]

Please backout this change as we don't need this change anymore as discussed in OCECDR-5250

to use only ModuleOnly attribute value to.

Comment entered 2023-06-22 11:11:12 by Kline, Bob (NIH/NCI) [C]

Backed out (DEV and QA).

Comment entered 2023-06-22 11:42:31 by Osei-Poku, William (NIH/NCI) [C]

We decided not to continue with this modification.

Elapsed: 0:00:00.001006