Issue Number | 5230 |
---|---|
Summary | Modify Publishing Filters to Remove links to blocked DIS |
Created | 2023-04-17 18:18:55 |
Issue Type | Bug |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2023-04-17 19:54:10 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.343671 |
When a DIS that has been linked to from a drug term on Cancer.gov is blocked, the link (tab) remains but the link is broken because the DIS is no longer on Cancer.gov. Please modify the publishing filters so that the links to blocked DIS documents are removed as part of the publishing process.
Example on PROD.
746606 - Blocked DIS
43407 - Drug term
The filter changes have been implemented on DEV:
CDR000134 - Vendor Filter: Term
https://github.com/NCIOCPL/cdr-server/commit/d494fd7
This is ready for review on DEV.
How do you suggest we test this on DEV?
Create a similar situation on DEV by blocking a DIS and making changes to the linking drug term and then a hot fix after that?
Yes, you block a DIS and then you republish that related drug term. No additional changes - besides the blocking of the DIS - will be necessary.
These are the blocked DISs on DEV.
CDR0000724471
CDR0000801597
CDR0000533338
And these are the Drug terms.
CDR0000352181
CDR0000795698
CDR0000039515
~oseipokuw prepared the document on DEV and I ran a nightly publishing job. The publishing job failed because of issues with other documents (Summaries without browser title) but I was able to confirm that the nightly publishing job picked up the three drug term documents for which the DIS documents were blocked.
Then I ran a hot-fix publishing job for the three drug terms followed by a drug dictionary refresh. After adjusting the Druapl DEV config file to point to the DEV drug dictionary (all tiers are pointing to the PROD APIs by default) we were able to confirm that the links to the DIS documents were removed.
Verified on DEV. Thanks!
The filter changes have been copied to STAGE.
I assume the Browser title ticket OCECDR-5104 is blocking this ticket also?
The filter changes are for a different document type and we don't need to produce partner output, although we probably want to double-check that the partner output is not affected.
The filter changes have been copied to QA.
Hi ~volker Are these changes now on PROD ?
We had copied these changes to STAGE for you to review but then said, with Pauling testing on QA almost done, we wanted to wait and test on QA instead of using STAGE. I copied the changes to QA last Thursday and that's where they are waiting for your review. Once you confirm everything looks good we can move the filter changes to the upper tiers.
I should have said: Once you prepared a document or two and we ran a publishing job you will be able to review the results to confirm everything looks good ...
These have been blocked on QA:
Axitinib CDR724471 (drug term CDR352181)
Daratumumab and Hyaluronidase-fihj CDR801597 (drug term CDR795698)
Cisplatin CDR533338 (drug term CDR39515)
I ran a nightly publishing job followed by a drug dictionary update. ~oseipokuw confirmed that the links on the TEST site were removed once the API had been redirected to the appropriate dictionary.
If you're OK with it, ~oseipokuw , I will go ahead and push the changes to the upper tiers.
Yes, please push the changes to the upper tiers. Thanks!
The filter changes have been pushed to STAGE and PROD.
Please verify after the next publishing job and close this ticket.
Verified on Cancer.gov. Thanks!
File Name | Posted | User |
---|---|---|
View Paitent Information link.png | 2023-04-17 18:17:57 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.002122