| Issue Number | 5149 |
|---|---|
| Summary | [Media] Modify Media QC report to display markup |
| Created | 2022-09-28 17:30:11 |
| Issue Type | Improvement |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-10-27 19:41:37 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.328701 |
As a CDR editor, I want to be able to run the media side by side QC report for documents that contain markup and have them display so that I can effectively QC them
Acceptance Criteria:
Scenario: Media QC report is able to display markup
Given I am a CDR editor
And I have permissions to create or modify media documents
When I create or modify a media document that has markup
And I run the Media side by side QC report
Then I want to be able to see the markup displayed as part of the report
~oseipokuw, is there a document with markup on PROD that I could look at as an example?
~volker This is an example on PROD - CDR0000726868
~oseipokuw is going to discuss with his group if it would make more sense to modify the Media QC report instead. Currently neither report is displaying insertion/deletion markup. I'not sure if the intention had been to use the Media side-by-side report as a replacement for the regular Media QC report. When I'm looking at both of the reports implementation I can see that it would certainly complicate the side-by-side report significantly while the addition of markup to the QC report appears to be mostly (all?) done via filter changes.
Please proceed to update the Media QC report instead. We will continue to use the side-by-side report just as we have been using it and not for reviewing markups in the documents.
I adjusted the title to reflect the decision to leave the side-by-side report alone.
~oseipokuw, would you need the ability to select the document version similar to summaries and DIS or display the current document like glossaries and terms?
Please display the changes in the CWD.
~oseipokuw, do I remember correctly that image documents aren't containing multiple languages anymore? The labels, description, and captions carry the language attribute but I only see the documents contain a single language. In fact, the media title has "-Spanish" added for Spanish documents.
If this is correct should I go ahead and drop the language display from the QC report?
Your observation is accurate. However, there are still some images that are shared by both languages. They are HP images that are not or cannot be translated due to permission issues or they could be illustrations that could be used without a translation. My understanding is that they are rare.
This report is almost ready but before I fine tune the remaining pieces I'd like ~oseipokuw to take a quick look. This is a report that had not been modified in a while and was using a lot of tables for positioning content. I have removed those tables to align the look-and-feel of the report with most of our other QC reports. In my opinion, the report is cleaner now and easier to read but I'm not the target.
Please take a look and let me know if this works.
Could you give me an example of one or two of those images? I want to see how we may need to adjust the display so that it will still work appropriately.
fecal occult blood test (415502)
I finished the changes and looked at the fecal occult Blood test example you listed. I would say it still displays good enough even without the language attribute displayed but if needed I can pull the language information onto the report and display it maybe as part of the label next to the audience. The following filter has been modified:
CDR433163 - Media QC Report Filter
This is ready for review on DEV.
I think this looks good as it is now. I will let you know if we want the language designation displayed.
Verified on QA
Verified on PROD. Thanks!
Elapsed: 0:00:00.000533