CDR Tickets

Issue Number 5061
Summary [QC Report] Replace KeyPoints Test
Created 2021-10-22 12:21:10
Issue Type Task
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2021-11-29 16:22:27
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.301085
Description

For one or two of our QC filters we are using the existence of a KeyPoint element as a deciding indicator for a patient summary.  With KeyPoints being removed from SVPC documents we'll have to modify this test.

I see the KeyPoints used in 

  • CDR433163.xml - Media QC Report Filter

  • CDR482943.xml - Module: Summary Denormalization

Comment entered 2021-11-29 16:22:14 by Englisch, Volker (NIH/NCI) [C]

The two filters used KeyPoints in order to identify a document to be a "reformatted" patient summary or not.  I left the original test in place for legacy summaries but also included to test the summary audience.  The following filters have been modified:

  • CDR433163.xml - Media QC Report Filter

  • CDR482943.xml - Module: Summary Denormalization

https://github.com/NCIOCPL/cdr-server/commit/230fa3e

A media document with a "Proposed Use" Summary entry will display a link to the summary QC report.  This link includes the ReportType variable that's set to either rs or pat based on the summary audience.

This is ready for review on DEV.

Comment entered 2021-12-02 09:35:41 by Osei-Poku, William (NIH/NCI) [C]

Hi Volker  Can you provide some guidance on how to test this?

Comment entered 2021-12-06 17:08:05 by Englisch, Volker (NIH/NCI) [C]

If you have an image file with HP and patient captions and the ProposedUse element linking to a patient summary, you would want the link to that summary in the Media QC report to link to the Patient version of the summary.  By default, any link to a summary is created using the HP version.

The URL to the summary would either include a parameter "... ReportType=rs..." for the HP version or "...ReportType=pat..." for the patient version.

Comment entered 2021-12-07 17:05:50 by Osei-Poku, William (NIH/NCI) [C]

Thanks, Volker.  I looked at several Media QC reports and the Proposed links are going to the correct QC report.

Do I also have to test the summary modules too?

Comment entered 2021-12-07 17:26:25 by Englisch, Volker (NIH/NCI) [C]

No, that's not necessary.  These filters are only used for the Media QC report.

Comment entered 2021-12-08 09:31:05 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2022-05-26 13:47:26 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA and PROD. Thanks!

Attachments
File Name Posted User
Screen Shot 2021-12-06 at 17.01.51.png 2021-12-06 17:05:41 Englisch, Volker (NIH/NCI) [C]

Elapsed: 0:00:00.001466