CDR Tickets

I modified the following filter but I'm currently unable to test the modifications due to the scheduler not running:

• CDR800355: Index Glossary Dictionary

I've updated a glossary term and included a GeneName element.  The result of the marked-up text can be seen in this screenshot.

These changes were already implemented as part of OCECDR-4928.

No additional filter changes were necessary.

~oseipokuw, if you go ahead and markup a few glossaries (gene name, scientific name, strong, italics are all part of this change) I can go ahead and publish those and then refresh the DEV glossary dictionary.

Hi ~volker These two are ready for publishing on DEV. 

CDR0000045851

CDR0000046539

I'm attaching the output for the two published glossary terms coming from the DEV glossary API:

When you have time please run PP for the following terms and attach the screenshots - 776823 and 802877.

Here are the screenshots for the two terms:

CALR gene - before

CALR gene - after

CDK6 gene - before

CDK6 gene - after

Thanks, Volker. When you have time, please generate PP for the following terms: 561237,561325, 721259 and 721252

Which screenshots do you need?  English, Spanish, or both?

The screenshots for the Spanish content.

I don't see any changes for 2 of the 4 Spanish terms.  Hope that's expected.

  don't see any changes for 2 of the 4 Spanish terms.  Hope that's expected.

This is because the tags are in the Replacement Text in the GTN.  Please see - 721252.

So, is the problem that you're not allowed to include a PlaceHolder element in the definition of the GTC or that the GeneName tag in the GTN document isn't carried over to the definition?

This is not a typical use. The reason for this case is that, there are multiple terms linking to the same definition and the the text that needs to be italicized must not  display in one of them. The only logical way is to use the Placeholder/Replacement team feature.

Thanks for the info, ~oseipokuw.  I will take a look once I'm done with the media report to see how big of an effort these changes would be.

This is not a typical use. The reason for this case is that, there are multiple terms linking to the same definition and the the text that needs to be italicized must not  display in one of them.

This sounds to me that you have two different replacements, one being "ALK" and one being "<emphasis>ALK</emphasis>" but you want to handle these with one replacement text element.  Wouldn't it make more sense to use two different replacements in this situation?

Would you be able to provide an example of this situation?

I've modified the filters to process GeneName and ScientificName element used inside the ReplacementText elements.  The following filters have been modified:

• CDR0000616048.xml - Vendor Filter: GlossaryTermName

• CDR0000800355.xml - Index Glossary Dictionary

This is ready for review on DEV.

Here is the screenshot for the Spanish definition of ALK gene:

Verified on DEV. Thanks!

Hi Volker ~volker I assume we repeat the same process as we did on DEV? That is, marking up the documents and providing you with the IDs for the screenshots?

Yep, that works for me if seeing the screenshots gives you enough information.

I just added gene name tags within the definition of BRCA1 (GTN is CDR46047) if you want to use that as an example for testing in the glossary.

I have published that glossary and confirmed that everything is working correctly but I'm currently unable to make any changes to the QA server because of a Drupal release that's being applied and tested today on QA.  I will provide the screenshots when that's possible again.

Running diff reports on QA shows that there is an issue with the substitution of the Spanish PlaceHolder for the vendor term output.

I reopened the ticket to fix it.

The following filter has been updated to fix the display of the missing replacement text.

• CDR616048 - Vendor Filter: GlossaryTermName
  https://github.com/NCIOCPL/cdr-server/commit/e71a5bbd

The differences that still exist are either marked-up text (GeneName, ScientificName, etc.) or MedialLinks (audio) that have been added.  I did not find any other changes which I did not expect for the 150 documents showing differences.

Here is the screenshot for BRCA1 from QA:

Do you want us to retest this on DEV?

The change has been installed on QA in order to rerun the diff reports, so you can test this on QA.

Please generate PP screenshots for the following docs. 

721252
561237
561325
804621
346515
721252

~oseipokuw, you are asking for PP screenshots for those documents but none of the previous screenshots came from the PP report.  Instead, I created those from the Cancer.gov DEV site.   In order to copy apples with apples the screenshots should come from the Cancer.gov QA/TEST site.

This is especially true since the PP report for glossaries will not show these marked up elements.  It would require a code changes to the PP report to display these changes here as well.

~oseipokuw, you are asking for PP screenshots for those documents but none of the previous screenshots came from the PP report.  Instead, I created those from the Cancer.gov DEV site.   In order to copy apples with apples the screenshots should come from the Cancer.gov QA/TEST site.

Sure. Please generate the screenshots from the Cancer.gov test site.

This is especially true since the PP report for glossaries will not show these marked up elements.  It would require a code changes to the PP report to display these changes here as well.

I didn't realize that was the case. Ultimately we would want to be able to view the changes in PP.

Here are the screenshots from QA of those 5 documents (one was a duplicate).

ALK gene

BCR-ABL fusion gene

BRAF gene

amivantamab

Adriamycin

For  721259 and 721252 could you please provide the screenshots of the Spanish terms?

Verified on QA. Thanks!

Verified on PROD/Cancer.gov. I will create a ticket to modify PP to display these changes.