CDR Tickets

Issue Number 4893
Summary Modify audio pronunciations import programs naming convention
Created 2020-09-18 08:58:08
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2020-10-02 13:37:55
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.274969
Description

Please modify the audio pronunciations import programs to use the current week and following the ISO week-numbering system as you suggested in OCECDR-4863.

 

Comment entered 2020-09-30 18:00:08 by Kline, Bob (NIH/NCI) [C]

Will we be able to make a clean switch to the new numbering system, or will there be a batch using the old arbitrary numbering system still in the pipeline, ?

Comment entered 2020-09-30 19:29:52 by Osei-Poku, William (NIH/NCI) [C]

We can make a clean switch. That is, I will not generate a new spreadsheet on PROD until this modification has been released.

Comment entered 2020-10-01 12:45:58 by Kline, Bob (NIH/NCI) [C]

Good. Here are the tasks which will need to be performed for this ticket, then.

  1. Add generation of filenames with the new naming pattern to AudioRequestSpreadsheet.py

  2. Change the expected filename pattern in the FtpAudio.py download script

  3. Change the expected filename patterns in GlossaryTermAudioReview.py

  4. Change the expected filename patterns in LoadGlossaryAudioFiles.py

  5. Archive sets created with the old naming schema (using the file sweeper)

  6. Perform end-to-end testing of the entire workflow pipeline

Comment entered 2020-10-01 15:32:56 by Kline, Bob (NIH/NCI) [C]

✔ Add generation of filenames with the new naming pattern
✔ Change the expected patterns in the download script
✔ Change the expected patterns in the review script
✔ Change the expected patterns in the import script
✔ Archive sets created with the old naming schema

Comment entered 2020-10-02 11:31:17 by Kline, Bob (NIH/NCI) [C]

I have added the following spec to the file-sweeper specifications on DEV and I ran a sweep job to archive sets which used the older naming pattern. We'll need to do this on all the tiers.

  <SweepSpec Tiers="PROD STAGE QA DEV">
    <Name>Archive legacy audio files on all tiers</Name>
    <Action>Archive</Action>
    <InputRoot>/cdr/Audio_from_CIPSFTP</InputRoot>
    <InputFiles>
      <File>Week_???.zip</File>
      <File>Week_???_Rev?.zip</File>
    </InputFiles>
    <OutputFile>/cdr/Audio_from_CIPSFTP/JobArchive/LegacyAudio</OutputFile>
    <Oldest>2</Oldest>
    <Youngest>1</Youngest>
  </SweepSpec>
Comment entered 2020-10-02 13:37:55 by Kline, Bob (NIH/NCI) [C]

Modifications installed on DEV.

Comment entered 2020-10-12 09:39:56 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2020-11-19 10:34:44 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2020-12-16 14:19:05 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Comment entered 2020-12-16 14:19:51 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD.  Thanks!

Elapsed: 0:00:00.001359