CDR Tickets

Here are some representative test cases.

https://cdr-dev.cancer.gov/cgi-bin/cdr/gpp.html

(Any GTN CDR ID can be plugged in to the id=... parameter.)

I will plug this into PublishPreview.py once I've gotten feedback on this implementation.

Known issues:

• the font for the More Information header is wrong; if that's important (I would guess not) we can address it in Maxwell (the issue is in the current implementation, and has been there for a while)

• I'm currently only showing one definition per language; I'm working on a modification to show them all

I have finished the modification to show all the definitions. For example, https://cdr-dev.cancer.gov/cgi-bin/cdr/GlossaryPublishPreview.py?id=45151.

So https://cdr-dev.cancer.gov/cgi-bin/cdr/gpp.html is ready for review. Let me know if you want me to add any other terms to that set.

Feedback from CIAT. 

1. Links from PP to a DIS aren’t working (“This site can’t be reached” error) – please see 45714 (human papilloma virus)

2.  Más Información Definition of:  shouldn´t include alternate Spanish name(s).  Please see attached screenshot. 

3.  Embedded video

    Can the  alignment for images and video be fixed to show both in the middle of the page?

    4.   Multiple Images  **When there are more thank 2 images, for example 4 images (720258), the first two images are  placed side by side horizontally but the next two are placed vertically. Can you please change that so that the next two are also placed horizontally as well?

I'm thinking it may be a good idea to wait with the improvements mentioned under item (4) until after the new dictionary API has been implemented.  I agree with your request, ~oseipokuw, but we do want the PP for glossaries to look as close to the published version as possible.  Neither the current nor the requested implementation reflects the way images are being displayed on the live site at the moment.
I personally would first like to see what's possible when using the new API and then adjust the PP report to match that.  (That's my $0.02)

For #2, the re-implementation matches what the original is doing. That in turn is using what the vendor export filter is producing for that term. If we're going to change that we'll want a separate ticket to have the filters changed. If you look at https://www.cancer.gov/espanol/publicaciones/diccionario/def/segundo-cancer-primario you'll see the same thing.

For #3, we're using the same style sheets which are used on the web site, and the alignment is working the same way. As Volker recommended for #4, it would probably make more sense if we're not happy with the alignment in the dictionary on cancer.gov to focus our efforts on correcting the original problem. Making the preview reflect the desired layout better than what we're previewing isn't really solving the real problem.

I have fixed the first problem (DIS links broken). Please try again.

Yes, it works. Thanks!

Pub preview looks good on DEV. We have a just a couple of enhancements (which can wait to be fixed later). 

1. It seems no space is created the Spanish definition and images for terms without "For more information (Más información)" section. Example: 7726062. 
    
   

2.  Please center videos instead of the current right-alignment. Example: 46658

1. For the first item it appears that the class related-resources is missing a style of "margin-top: 40px".  

2. For the second item we discussed that we want the output for the PP report replicate the output on Cancer.gov as closely as possible.  The display/alignment of videos on Cancer.gov is currently identical to the display of of videos on the PP report. 
   An alignment change should first be implemented on Cancer.gov before we adjust the PP report accordingly.