CDR Tickets

Issue Number 4840
Summary Upgrade CGI scripts
Created 2020-06-08 22:34:58
Issue Type Improvement
Submitted By Kline, Bob (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2020-09-21 09:33:37
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.263637
Description

The following scripts need to be modified to use the current report framework used for the CDR Admin interface.

  • MediaCaptionContent.py

  • DrugReviewReport.py

  • SummaryMailerReqForm.py

(The QC report script also uses the older manual techniques for creating forms and reports, but its requirements are complex enough that a rewrite would warrant its own ticket. An earlier effort to upgrade that script was abandoned when it became necessary to restore some original behaviors at the last minute for a pending release. We'll save that for another day.)

Comment entered 2020-09-17 10:28:19 by Kline, Bob (NIH/NCI) [C]

The Media Caption/Content report has been rewritten. The new version is on DEV under a temporarily modified name so the old and new versions can be compared side-by-side. In particular you'll notice that sometimes the original version tripped on a bug in the spreadsheet-generation package, causing images to be stretched/distorted. I introduced a workaround for that bug.

https://cdr-dev.cancer.gov/cgi-bin/cdr/MCC.py

Comment entered 2020-09-21 09:33:23 by Kline, Bob (NIH/NCI) [C]

All three scripts have been rewritten. As with the Media Caption/Content report, I have installed the new versions under temporary names to facilitate side-by-side comparison. You'll notice that another bug has been fixed, which caused the summary links in the advisory board mailer trackers report to be broken. For that script (SMRF.py) you have to be logged in with credentials allowed to create mailers, so you will need to log into https://cdr-dev.cancer.gov and then edit the URL in the browser address bar, replacing Admin.py with SMRF.py.

https://cdr-dev.cancer.gov/cgi-bin/cdr/DRR.py https://cdr-dev.cancer.gov/cgi-bin/cdr/DRR.py
https://cdr-dev.cancer.gov/cgi-bin/cdr/MCC.py
https://cdr-dev.cancer.gov/cgi-bin/cdr/SMRF.py?Session=YOUR-SESSION-ID-HERE

Comment entered 2020-10-08 07:49:03 by Kline, Bob (NIH/NCI) [C]

The obsolete classes on which the older versions of these scripts depended have been removed on DEV, so the new versions of the scripts are now installed under their own names. Until we deploy Maxwell to QA, the previous versions of the scripts can be run on that tier.

Comment entered 2020-10-29 15:44:16 by Juthe, Robin (NIH/NCI) [E]

I verified that the following script is working as expected on DEV.

  • SummaryMailerReqForm.py

Comment entered 2020-10-30 10:59:44 by Osei-Poku, William (NIH/NCI) [C]

  • MediaCaptionContent.py

  • DrugReviewReport.py

Have been verified on DEV. Thanks!

Comment entered 2020-11-20 19:17:37 by Osei-Poku, William (NIH/NCI) [C]

  • MediaCaptionContent.py

  • DrugReviewReport.py

The above reports have been verified on QA.

Comment entered 2020-12-03 13:21:28 by Juthe, Robin (NIH/NCI) [E]

I just noticed this one is likely waiting on me to test the summary mailer form (sorry!), but I can't get to QA right now.

Comment entered 2020-12-03 13:31:26 by Juthe, Robin (NIH/NCI) [E]

Nevermind, I'm on QA now and the following script is working as expected: 

  • SummaryMailerReqForm.py

Comment entered 2020-12-03 13:31:36 by Juthe, Robin (NIH/NCI) [E]

Verified on QA.

Comment entered 2020-12-21 12:06:00 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Elapsed: 0:00:00.001483