| Issue Number | 4646 |
|---|---|
| Summary | [DIS] Add CSS to comments display in DIS |
| Created | 2019-08-09 12:41:11 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2020-04-13 13:25:31 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.248211 |
Please adjust the CSS to properly display comments in DIS, including comments inside list items and para elements. Per a comment from Volker in OCECDR-4508:
"First of all I'm guessing you would need an additional ticket to adjust the CSS for XMetaL because the comments aren't displayed properly, i.e. inside lists or a para level comment doesn't get displayed with the Comment-label or the green background."
It appears that the Para element comments have already been corrected. Those display correctly.
I will only need to address the comments within ListItem elements.
The following CSS files have been updated for this ticket:
DrugInformationSummary.css
DrugInformationSummary_Structure.css
https://github.com/NCIOCPL/cdr-client/commit/c6acccb5
This is ready for review on DEV.
Verified on DEV. Thanks!
This looks good to me on DEV too, although comments are allowed in other locations in the DIS that don't have CSS. (e.g., within table elements and itemized list elements). So we may want to address the CSS in those locations too in the future if we find we want to add comments in those locations as well.
Comments within ListItem elements are already marked up correctly. I've added the CSS for Comments within table cells. The following files have been updated:
DrugInformationSummary.css
DrugInformationSummary.ctm
Verified on DEV. Thanks!
Verified on QA. Thanks!
Elapsed: 0:00:00.001358