CDR Tickets

Issue Number 4573
Summary [Summaries] Remove Advisory Board Mailers from the CDR (But Preserve Tracking Capability)
Created 2019-02-21 12:44:59
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2019-08-12 15:04:22
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.240496
Description

We no longer use the Advisory Board mailers in the CDR. However, we would still like to track when Advisory Board members received a copy of the summary to review and record whether or not they responded using a mailer tracking doc.

So, I believe we discussed modifying the system to allow for mailer tracking IDs to be generated "on the fly" using the existing AB mailer interface (or something very similar, allowing for the selection of summaries and Board members) without requiring a mailer to be generated using the publishing system.

Comment entered 2019-07-02 18:37:03 by Kline, Bob (NIH/NCI) [C]

As far as I can tell, there is no interface for generating mailers for editorial board members. Is this right? I guess that would mean we can retire all the LaTeX software.

Comment entered 2019-07-03 06:43:55 by Kline, Bob (NIH/NCI) [C]

Collecting my questions in one place.

  1. Can we retire the LaTeX software completely?

  2. Should the required Mode attribute be Mail or Web-based?

  3. If we don't use the publishing system, should we modify the schema to make the Job element optional, or use 0 for its value?

  4. What should the value of the Deadline element be?

  5. Should Sent still be the date the tracking document was generated?

  6. Or should some different document type be used for this?

Over to you, Robin, for these questions.

Comment entered 2019-07-03 18:16:16 by Kline, Bob (NIH/NCI) [C]

While you're mulling over these questions, I'm going to try and get as much tentative work done on the ticket as I can, going with the assumptions that

  • We'll keep the Mailer document type

  • I can leave out the JobId element (I just realized it's already optional)

  • The other answers can easily be plugged into whatever I've put together when I get them

Comment entered 2019-07-05 10:06:41 by Kline, Bob (NIH/NCI) [C]

Sorry for all the noise. I worked out the obvious answers for most of my questions. The enhancement has been implemented on DEV. One of the advantages of the new approach is that you can test more freely, not having to worry about adding jobs to the publishing table or LaTeX mailers added to the file system.

I used Web-based as the value for the Mode attribute, but we may want to consider the new value Tracker to reflect this new usage of the Mailer document type. And I still need confirmation that the LaTeX software can be removed from the servers.

Comment entered 2019-07-11 10:10:21 by Juthe, Robin (NIH/NCI) [E]

I've added my responses to your questions below.

 

Collecting my questions in one place.

  1. Can we retire the LaTeX software completely? RJ: Yes, we can retire it as long as this isn't used for the mailers sent to the genetics professionals. We no longer need to generate summary mailers (Ed Board mailers were removed several years ago).

  2. Should the required Mode attribute be Mail or Web-based? RJ: Web-based sounds good to me.

  3. If we don't use the publishing system, should we modify the schema to make the Job element optional, or use 0 for its value? RJ: I don't see any reason to keep this number. It sounds like you came to the same conclusion. 🙂

  4. What should the value of the Deadline element be? RJ: I don't know what this means.

  5. Should Sent still be the date the tracking document was generated? RJ: Yes.

  6. Or should some different document type be used for this? RJ: The same document type is fine for now. Thanks!

Over to you, Robin, for these questions.

Comment entered 2019-08-09 17:31:12 by Juthe, Robin (NIH/NCI) [E]

This is looking good on QA but could you please remove blocked summaries from the list of available summaries for which to generate mailer tracking documents? Thanks.

Comment entered 2019-08-10 11:24:31 by Kline, Bob (NIH/NCI) [C]

Could you give me an example of a blocked summary for which a tracking document is generated? I don't believe the logic for selecting the summaries has changed.

Comment entered 2019-08-12 13:25:12 by Juthe, Robin (NIH/NCI) [E]

False alarm! The Peds summary Genomics of Thyroid Cancer*BLOCKED* [Module];Treatment;Health professionals has mailer tracking documents generated, but the document is not actually blocked in the system (just has that manually appended to the title).

Comment entered 2019-08-12 13:25:34 by Juthe, Robin (NIH/NCI) [E]

Verified on QA.

Comment entered 2019-08-12 14:16:57 by Juthe, Robin (NIH/NCI) [E]

Sorry, but it turns out I spoke too soon. Upon logging out of QA, I was presented with a very large message about checked-out documents. Apparently the mailer tracking software is checking out all of the mailer tracking docs to whomever generated them, which would mean only that person could check in the responses. The mailer tracking documents should be created but automatically checked back in.

Comment entered 2019-08-12 15:04:22 by Kline, Bob (NIH/NCI) [C]

Sorry about that. Fixed on QA, I think. I have unlocked the mailers. I will add the fix to the deployment package and apply it to DEV after you have tested on QA and confirmed that the fix is correct.

Comment entered 2019-08-12 16:13:27 by Juthe, Robin (NIH/NCI) [E]

Looks good on QA. Thanks!

Comment entered 2019-08-27 13:03:35 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD.

Elapsed: 0:00:00.001492